Re: [Intel-gfx] [PATCH 3/3] drm/i915: Remove HAS_FULL_PPGTT and device_info.ppgtt enum (v3)

2019-03-14 Thread Chris Wilson
Quoting Bob Paauwe (2019-03-14 20:09:57) > Chris, > > Any thoughts on how I can best address your comment on this patch? I do not see the value in this patch as it is. Don't remove intel_device_info.ppgtt; rename it to ppgtt_mode. Put ppgtt_size alongside. Ie keep using intel_device_info.ppgtt_m

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Remove HAS_FULL_PPGTT and device_info.ppgtt enum (v3)

2019-03-14 Thread Bob Paauwe
Chris, Any thoughts on how I can best address your comment on this patch? Bob On Thu, 7 Feb 2019 11:13:15 -0800 Bob Paauwe wrote: > On Thu, 7 Feb 2019 16:41:58 + > Chris Wilson wrote: > > > Quoting Bob Paauwe (2019-02-07 16:29:53) > > > With the address range being specified for each p

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Remove HAS_FULL_PPGTT and device_info.ppgtt enum (v3)

2019-02-07 Thread Bob Paauwe
On Thu, 7 Feb 2019 16:41:58 + Chris Wilson wrote: > Quoting Bob Paauwe (2019-02-07 16:29:53) > > With the address range being specified for each platform, we can use > > that instead of the .ppgtt enum to handle the differences between > > 3 level and 4 level PPGTT. In most cases, we really o

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Remove HAS_FULL_PPGTT and device_info.ppgtt enum (v3)

2019-02-07 Thread Chris Wilson
Quoting Bob Paauwe (2019-02-07 16:29:53) > With the address range being specified for each platform, we can use > that instead of the .ppgtt enum to handle the differences between > 3 level and 4 level PPGTT. In most cases, we really only care if the > platform supports PPGTT or not. Because of thi

[Intel-gfx] [PATCH 3/3] drm/i915: Remove HAS_FULL_PPGTT and device_info.ppgtt enum (v3)

2019-02-07 Thread Bob Paauwe
With the address range being specified for each platform, we can use that instead of the .ppgtt enum to handle the differences between 3 level and 4 level PPGTT. In most cases, we really only care if the platform supports PPGTT or not. Because of this, we can now remove the HAS_FULL_PPGTT macro and