Re: [Intel-gfx] [PATCH 3/4] drm/i915: Use full serialisation around engine->irq_posted

2018-03-31 Thread Chris Wilson
Quoting Chris Wilson (2018-03-31 00:08:47) > Quoting Chris Wilson (2018-03-22 07:35:32) > > Using engine->irq_posted for execlists, we are not always serialised by > > the tasklet as we supposed. On the reset paths, the tasklet is disabled > > and ignored. Instead, we manipulate the

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Use full serialisation around engine->irq_posted

2018-03-30 Thread Chris Wilson
Quoting Chris Wilson (2018-03-22 07:35:32) > Using engine->irq_posted for execlists, we are not always serialised by > the tasklet as we supposed. On the reset paths, the tasklet is disabled > and ignored. Instead, we manipulate the engine->irq_posted directly to > account for the reset, but if an

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Use full serialisation around engine->irq_posted

2018-03-22 Thread Chris Wilson
Quoting Jeff McGee (2018-03-22 15:34:45) > On Thu, Mar 22, 2018 at 07:35:32AM +, Chris Wilson wrote: > > Using engine->irq_posted for execlists, we are not always serialised by > > the tasklet as we supposed. On the reset paths, the tasklet is disabled > > and ignored. Instead, we manipulate

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Use full serialisation around engine->irq_posted

2018-03-22 Thread Jeff McGee
On Thu, Mar 22, 2018 at 07:35:32AM +, Chris Wilson wrote: > Using engine->irq_posted for execlists, we are not always serialised by > the tasklet as we supposed. On the reset paths, the tasklet is disabled > and ignored. Instead, we manipulate the engine->irq_posted directly to > account for

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Use full serialisation around engine->irq_posted

2018-03-22 Thread Mika Kuoppala
Chris Wilson writes: > Using engine->irq_posted for execlists, we are not always serialised by > the tasklet as we supposed. On the reset paths, the tasklet is disabled > and ignored. Instead, we manipulate the engine->irq_posted directly to > account for the reset, but

[Intel-gfx] [PATCH 3/4] drm/i915: Use full serialisation around engine->irq_posted

2018-03-22 Thread Chris Wilson
Using engine->irq_posted for execlists, we are not always serialised by the tasklet as we supposed. On the reset paths, the tasklet is disabled and ignored. Instead, we manipulate the engine->irq_posted directly to account for the reset, but if an interrupt fired before the reset and so wrote to