Re: [Intel-gfx] [PATCH 3/5] drm/i915: Trim the command parser allocations

2015-02-23 Thread Daniel Vetter
On Fri, Feb 13, 2015 at 04:43:22PM +, John Harrison wrote: > On 13/02/2015 13:23, Chris Wilson wrote: > >On Fri, Feb 13, 2015 at 01:08:59PM +, John Harrison wrote: > >>>@@ -1155,40 +1154,30 @@ i915_gem_execbuffer_parse(struct intel_engine_cs > >>>*ring, > >>> batch_

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Trim the command parser allocations

2015-02-13 Thread John Harrison
On 13/02/2015 13:23, Chris Wilson wrote: On Fri, Feb 13, 2015 at 01:08:59PM +, John Harrison wrote: @@ -1155,40 +1154,30 @@ i915_gem_execbuffer_parse(struct intel_engine_cs *ring, batch_start_offset, batch_len,

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Trim the command parser allocations

2015-02-13 Thread Chris Wilson
On Fri, Feb 13, 2015 at 01:08:59PM +, John Harrison wrote: > >@@ -1155,40 +1154,30 @@ i915_gem_execbuffer_parse(struct intel_engine_cs > >*ring, > > batch_start_offset, > > batch_len, > > is_master); > >-if (ret)

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Trim the command parser allocations

2015-02-13 Thread John Harrison
Hello, Apparently, I've been volunteered to review these patches despite not knowing too much about these areas of the driver... On 14/01/2015 11:20, Chris Wilson wrote: Currently, the command parser tries to create a secondary batch exactly as large as the original, and vmap both. This is op

[Intel-gfx] [PATCH 3/5] drm/i915: Trim the command parser allocations

2015-01-14 Thread Chris Wilson
Currently, the command parser tries to create a secondary batch exactly as large as the original, and vmap both. This is open to abuse by userspace using extremely large batch objects, but only executing very short batches. For example, this would be if userspace were to implement a command submiss