Re: [Intel-gfx] [PATCH 3/5] drm/i915: merge gen checks to use range

2018-11-02 Thread Rodrigo Vivi
On Fri, Nov 02, 2018 at 03:28:00PM -0700, Lucas De Marchi wrote: > On Fri, Nov 02, 2018 at 03:12:18PM -0700, Rodrigo Vivi wrote: > > On Fri, Nov 02, 2018 at 12:47:28PM -0700, Lucas De Marchi wrote: > > > On Fri, Nov 02, 2018 at 12:19:13PM -0700, Rodrigo Vivi wrote: > > > > On Fri, Nov 02, 2018 at

Re: [Intel-gfx] [PATCH 3/5] drm/i915: merge gen checks to use range

2018-11-02 Thread Lucas De Marchi
On Fri, Nov 02, 2018 at 03:12:18PM -0700, Rodrigo Vivi wrote: > On Fri, Nov 02, 2018 at 12:47:28PM -0700, Lucas De Marchi wrote: > > On Fri, Nov 02, 2018 at 12:19:13PM -0700, Rodrigo Vivi wrote: > > > On Fri, Nov 02, 2018 at 11:10:10AM -0700, Lucas De Marchi wrote: > > > > On Thu, Nov 01, 2018 at

Re: [Intel-gfx] [PATCH 3/5] drm/i915: merge gen checks to use range

2018-11-02 Thread Rodrigo Vivi
On Fri, Nov 02, 2018 at 12:47:28PM -0700, Lucas De Marchi wrote: > On Fri, Nov 02, 2018 at 12:19:13PM -0700, Rodrigo Vivi wrote: > > On Fri, Nov 02, 2018 at 11:10:10AM -0700, Lucas De Marchi wrote: > > > On Thu, Nov 01, 2018 at 11:31:25AM +, Tvrtko Ursulin wrote: > > > > > > > > On 01/11/2018

Re: [Intel-gfx] [PATCH 3/5] drm/i915: merge gen checks to use range

2018-11-02 Thread Lucas De Marchi
On Fri, Nov 02, 2018 at 12:19:13PM -0700, Rodrigo Vivi wrote: > On Fri, Nov 02, 2018 at 11:10:10AM -0700, Lucas De Marchi wrote: > > On Thu, Nov 01, 2018 at 11:31:25AM +, Tvrtko Ursulin wrote: > > > > > > On 01/11/2018 08:35, Lucas De Marchi wrote: > > > > Instead of using several IS_GEN(),

Re: [Intel-gfx] [PATCH 3/5] drm/i915: merge gen checks to use range

2018-11-02 Thread Rodrigo Vivi
On Fri, Nov 02, 2018 at 11:10:10AM -0700, Lucas De Marchi wrote: > On Thu, Nov 01, 2018 at 11:31:25AM +, Tvrtko Ursulin wrote: > > > > On 01/11/2018 08:35, Lucas De Marchi wrote: > > > Instead of using several IS_GEN(), it's possible to pass the > > > range as argument. By code inspection

Re: [Intel-gfx] [PATCH 3/5] drm/i915: merge gen checks to use range

2018-11-02 Thread Lucas De Marchi
On Thu, Nov 01, 2018 at 11:31:25AM +, Tvrtko Ursulin wrote: > > On 01/11/2018 08:35, Lucas De Marchi wrote: > > Instead of using several IS_GEN(), it's possible to pass the > > range as argument. By code inspection these were the ranges deemed > > necessary for spatch: > > > > @@ > >

Re: [Intel-gfx] [PATCH 3/5] drm/i915: merge gen checks to use range

2018-11-01 Thread Tvrtko Ursulin
On 01/11/2018 08:35, Lucas De Marchi wrote: Instead of using several IS_GEN(), it's possible to pass the range as argument. By code inspection these were the ranges deemed necessary for spatch: @@ expression e; @@ ( - IS_GEN(e, 3) || IS_GEN(e, 4) + IS_GEN(e, 3, 4) | - IS_GEN(e, 5) || IS_GEN(e,

Re: [Intel-gfx] [PATCH 3/5] drm/i915: merge gen checks to use range

2018-11-01 Thread Jani Nikula
On Thu, 01 Nov 2018, Lucas De Marchi wrote: > Instead of using several IS_GEN(), it's possible to pass the > range as argument. By code inspection these were the ranges deemed > necessary for spatch: Again, ignoring the naming for now, I do like the idea here. BR, Jani. -- Jani Nikula, Intel

[Intel-gfx] [PATCH 3/5] drm/i915: merge gen checks to use range

2018-11-01 Thread Lucas De Marchi
Instead of using several IS_GEN(), it's possible to pass the range as argument. By code inspection these were the ranges deemed necessary for spatch: @@ expression e; @@ ( - IS_GEN(e, 3) || IS_GEN(e, 4) + IS_GEN(e, 3, 4) | - IS_GEN(e, 5) || IS_GEN(e, 6) + IS_GEN(e, 5, 6) | - IS_GEN(e, 6) ||