[Intel-gfx] [PATCH 3/6] drm/i915: Always prepare planes at the start of an atomic commit

2016-08-21 Thread Chris Wilson
The generic atomic helper likes to skip a prepare_plane_fb() if it decides that the plane->fb is unchanged. This is wrong for us for a couple of reasons: - if the pipe is reconfigured (i.e. a size change) but the framebuffer is untouched, we still have to flush any rendering prior to the re

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Always prepare planes at the start of an atomic commit

2016-08-22 Thread Chris Wilson
On Mon, Aug 22, 2016 at 10:02:52AM +0200, Daniel Vetter wrote: > On Sun, Aug 21, 2016 at 02:15:33PM +0100, Chris Wilson wrote: > > The generic atomic helper likes to skip a prepare_plane_fb() if it > > decides that the plane->fb is unchanged. This is wrong for us for a > > couple of reasons: > > >

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Always prepare planes at the start of an atomic commit

2016-08-22 Thread Daniel Vetter
On Sun, Aug 21, 2016 at 02:15:33PM +0100, Chris Wilson wrote: > The generic atomic helper likes to skip a prepare_plane_fb() if it > decides that the plane->fb is unchanged. This is wrong for us for a > couple of reasons: > > - if the pipe is reconfigured (i.e. a size change) but the framebuffer

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Always prepare planes at the start of an atomic commit

2016-08-23 Thread Daniel Vetter
On Mon, Aug 22, 2016 at 09:11:00AM +0100, Chris Wilson wrote: > On Mon, Aug 22, 2016 at 10:02:52AM +0200, Daniel Vetter wrote: > > On Sun, Aug 21, 2016 at 02:15:33PM +0100, Chris Wilson wrote: > > > The generic atomic helper likes to skip a prepare_plane_fb() if it > > > decides that the plane->fb

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Always prepare planes at the start of an atomic commit

2016-08-23 Thread Chris Wilson
On Tue, Aug 23, 2016 at 10:36:58AM +0200, Daniel Vetter wrote: > On Mon, Aug 22, 2016 at 09:11:00AM +0100, Chris Wilson wrote: > > On Mon, Aug 22, 2016 at 10:02:52AM +0200, Daniel Vetter wrote: > > > On Sun, Aug 21, 2016 at 02:15:33PM +0100, Chris Wilson wrote: > > > > The generic atomic helper lik