Re: [Intel-gfx] [PATCH 3/6] drm/i915: protect access to DP_TP_* on non-dp

2019-09-04 Thread Matt Roper
On Wed, Sep 04, 2019 at 02:34:16PM -0700, José Roberto de Souza wrote: > From: Lucas De Marchi > > DP_TP_{CTL,STATUS} should only be programmed when the encoder is intel_dp. > Checking its current usages intel_disable_ddi_buf() is the only > offender, with other places being protected by checks l

[Intel-gfx] [PATCH 3/6] drm/i915: protect access to DP_TP_* on non-dp

2019-09-04 Thread José Roberto de Souza
From: Lucas De Marchi DP_TP_{CTL,STATUS} should only be programmed when the encoder is intel_dp. Checking its current usages intel_disable_ddi_buf() is the only offender, with other places being protected by checks like pipe_config->fec_enable that is only set by intel_dp. v3 (José): - Using int