Re: [Intel-gfx] [PATCH 3/9] drm/i915/bdw: Split ppgtt initialization up

2014-02-20 Thread Imre Deak
On Wed, 2014-02-19 at 22:05 -0800, Ben Widawsky wrote: > Like cleanup in an earlier patch, the code becomes much more readable, > and easier to extend if we extract out helper functions for the various > stages of init. > > Note that with this patch it becomes really simple, and tempting to begin

[Intel-gfx] [PATCH 3/9] drm/i915/bdw: Split ppgtt initialization up

2014-02-19 Thread Ben Widawsky
Like cleanup in an earlier patch, the code becomes much more readable, and easier to extend if we extract out helper functions for the various stages of init. Note that with this patch it becomes really simple, and tempting to begin using the 'goto out' idiom with explicit free/fini semantics. I'v

Re: [Intel-gfx] [PATCH 3/9] drm/i915/bdw: Split ppgtt initialization up

2014-02-19 Thread Imre Deak
On Wed, 2014-02-12 at 14:28 -0800, Ben Widawsky wrote: > Like cleanup in an earlier patch, the code becomes much more readable, > and easier to extend if we extract out helper functions for the various > stages of init. > > Note that with this patch it becomes really simple, and tempting to begin

[Intel-gfx] [PATCH 3/9] drm/i915/bdw: Split ppgtt initialization up

2014-02-12 Thread Ben Widawsky
Like cleanup in an earlier patch, the code becomes much more readable, and easier to extend if we extract out helper functions for the various stages of init. Note that with this patch it becomes really simple, and tempting to begin using the 'goto out' idiom with explicit free/fini semantics. I'v