Re: [Intel-gfx] [PATCH 3/9] drm/i915/perf: Validate OA sseu config outside switch

2023-02-16 Thread Umesh Nerlige Ramappa
On Wed, Feb 15, 2023 at 09:36:50PM -0800, Dixit, Ashutosh wrote: On Wed, 15 Feb 2023 21:08:43 -0800, Dixit, Ashutosh wrote: On Tue, 14 Feb 2023 16:54:13 -0800, Umesh Nerlige Ramappa wrote: > > Validate the OA sseu config after all params are parsed. Commit messages for all patches need to answ

Re: [Intel-gfx] [PATCH 3/9] drm/i915/perf: Validate OA sseu config outside switch

2023-02-16 Thread Umesh Nerlige Ramappa
On Thu, Feb 16, 2023 at 08:31:21AM -0800, Dixit, Ashutosh wrote: On Wed, 15 Feb 2023 21:36:50 -0800, Dixit, Ashutosh wrote: On Wed, 15 Feb 2023 21:08:43 -0800, Dixit, Ashutosh wrote: > > On Tue, 14 Feb 2023 16:54:13 -0800, Umesh Nerlige Ramappa wrote: > > > > Validate the OA sseu config after a

Re: [Intel-gfx] [PATCH 3/9] drm/i915/perf: Validate OA sseu config outside switch

2023-02-16 Thread Dixit, Ashutosh
On Wed, 15 Feb 2023 21:36:50 -0800, Dixit, Ashutosh wrote: > > On Wed, 15 Feb 2023 21:08:43 -0800, Dixit, Ashutosh wrote: > > > > On Tue, 14 Feb 2023 16:54:13 -0800, Umesh Nerlige Ramappa wrote: > > > > > > Validate the OA sseu config after all params are parsed. > > > > Commit messages for all pat

Re: [Intel-gfx] [PATCH 3/9] drm/i915/perf: Validate OA sseu config outside switch

2023-02-15 Thread Dixit, Ashutosh
On Wed, 15 Feb 2023 21:08:43 -0800, Dixit, Ashutosh wrote: > > On Tue, 14 Feb 2023 16:54:13 -0800, Umesh Nerlige Ramappa wrote: > > > > Validate the OA sseu config after all params are parsed. > > Commit messages for all patches need to answer the "why" or the reason for > the patch. In this case m

Re: [Intel-gfx] [PATCH 3/9] drm/i915/perf: Validate OA sseu config outside switch

2023-02-15 Thread Dixit, Ashutosh
On Tue, 14 Feb 2023 16:54:13 -0800, Umesh Nerlige Ramappa wrote: > > Validate the OA sseu config after all params are parsed. Commit messages for all patches need to answer the "why" or the reason for the patch. In this case maybe an overkill but probably something like: Validate the OA sseu conf

[Intel-gfx] [PATCH 3/9] drm/i915/perf: Validate OA sseu config outside switch

2023-02-14 Thread Umesh Nerlige Ramappa
Validate the OA sseu config after all params are parsed. Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/i915_perf.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c inde