[Intel-gfx] [PATCH 31/49] drm/i915: Reduce locking in execlist command submission

2015-03-27 Thread Chris Wilson
This eliminates six needless spin lock/unlock pairs when writing out ELSP. v2: Respin with my preferred colour. Signed-off-by: Tvrtko Ursulin tvrtko.ursu...@intel.com Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk [v2] --- drivers/gpu/drm/i915/i915_drv.h | 18

Re: [Intel-gfx] [PATCH 31/49] drm/i915: Reduce locking in execlist command submission

2015-03-27 Thread Tvrtko Ursulin
On 03/27/2015 11:47 AM, Chris Wilson wrote: On Fri, Mar 27, 2015 at 11:40:12AM +, Tvrtko Ursulin wrote: +/* Like above but take and hold the uncore lock for the duration. + * Must be used with I915_READ_FW and friends. + */ +void intel_uncore_forcewake_irqlock(struct drm_i915_private

Re: [Intel-gfx] [PATCH 31/49] drm/i915: Reduce locking in execlist command submission

2015-03-27 Thread Tvrtko Ursulin
Hi, On 03/27/2015 11:02 AM, Chris Wilson wrote: This eliminates six needless spin lock/unlock pairs when writing out ELSP. v2: Respin with my preferred colour. Signed-off-by: Tvrtko Ursulin tvrtko.ursu...@intel.com Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk [v2] ---

Re: [Intel-gfx] [PATCH 31/49] drm/i915: Reduce locking in execlist command submission

2015-03-27 Thread Chris Wilson
On Fri, Mar 27, 2015 at 11:40:12AM +, Tvrtko Ursulin wrote: +/* Like above but take and hold the uncore lock for the duration. + * Must be used with I915_READ_FW and friends. + */ +void intel_uncore_forcewake_irqlock(struct drm_i915_private *dev_priv, +enum

Re: [Intel-gfx] [PATCH 31/49] drm/i915: Reduce locking in execlist command submission

2015-03-27 Thread Daniel Vetter
On Fri, Mar 27, 2015 at 11:47:12AM +, Chris Wilson wrote: On Fri, Mar 27, 2015 at 11:40:12AM +, Tvrtko Ursulin wrote: +/* Like above but take and hold the uncore lock for the duration. + * Must be used with I915_READ_FW and friends. + */ +void