[Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-08-20 Thread Umesh Nerlige Ramappa
i915 used to support time based sampling mode which is good for overall system monitoring, but is not enough for query mode used to measure a single draw call or dispatch. Gen9-Gen11 are using current i915 perf implementation for query, but Gen12+ requires a new approach for query based on

[Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-08-04 Thread Umesh Nerlige Ramappa
i915 used to support time based sampling mode which is good for overall system monitoring, but is not enough for query mode used to measure a single draw call or dispatch. Gen9-Gen11 are using current i915 perf implementation for query, but Gen12+ requires a new approach for query based on

[Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-31 Thread Umesh Nerlige Ramappa
i915 used to support time based sampling mode which is good for overall system monitoring, but is not enough for query mode used to measure a single draw call or dispatch. Gen9-Gen11 are using current i915 perf implementation for query, but Gen12+ requires a new approach for query based on

Re: [Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-31 Thread Chris Wilson
Quoting Umesh Nerlige Ramappa (2020-07-31 15:46:43) > i915 used to support time based sampling mode which is good for overall > system monitoring, but is not enough for query mode used to measure a > single draw call or dispatch. Gen9-Gen11 are using current i915 perf > implementation for query,

[Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-31 Thread Umesh Nerlige Ramappa
i915 used to support time based sampling mode which is good for overall system monitoring, but is not enough for query mode used to measure a single draw call or dispatch. Gen9-Gen11 are using current i915 perf implementation for query, but Gen12+ requires a new approach for query based on

Re: [Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-31 Thread Chris Wilson
Quoting Umesh Nerlige Ramappa (2020-07-31 07:07:23) > i915 used to support time based sampling mode which is good for overall > system monitoring, but is not enough for query mode used to measure a > single draw call or dispatch. Gen9-Gen11 are using current i915 perf > implementation for query,

[Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-31 Thread Umesh Nerlige Ramappa
i915 used to support time based sampling mode which is good for overall system monitoring, but is not enough for query mode used to measure a single draw call or dispatch. Gen9-Gen11 are using current i915 perf implementation for query, but Gen12+ requires a new approach for query based on

[Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-30 Thread Umesh Nerlige Ramappa
i915 used to support time based sampling mode which is good for overall system monitoring, but is not enough for query mode used to measure a single draw call or dispatch. Gen9-Gen11 are using current i915 perf implementation for query, but Gen12+ requires a new approach for query based on

Re: [Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-24 Thread Umesh Nerlige Ramappa
On Fri, Jul 24, 2020 at 08:46:16PM +0100, Chris Wilson wrote: Quoting Umesh Nerlige Ramappa (2020-07-24 20:35:11) I agree, but strangely, with mmap sequence below, I don't see i915_perf_release() called at all. So destroy() is not called. perf_fd = i915_perf_open_ioctl() mmap(..., perf_fd...)

Re: [Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-24 Thread Chris Wilson
Quoting Umesh Nerlige Ramappa (2020-07-24 20:35:11) > I agree, but strangely, with mmap sequence below, I don't see > i915_perf_release() called at all. So destroy() is not called. > > perf_fd = i915_perf_open_ioctl() > mmap(..., perf_fd...) > close(perf_fd) > delay for a few seconds. > > If I

Re: [Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-24 Thread Umesh Nerlige Ramappa
On Fri, Jul 24, 2020 at 07:55:06PM +0100, Chris Wilson wrote: Quoting Umesh Nerlige Ramappa (2020-07-24 19:47:37) On Fri, Jul 24, 2020 at 05:34:11PM +0100, Chris Wilson wrote: >Quoting Umesh Nerlige Ramappa (2020-07-24 17:29:56) >> On Fri, Jul 24, 2020 at 01:42:33PM +0100, Chris Wilson wrote:

Re: [Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-24 Thread Chris Wilson
Quoting Umesh Nerlige Ramappa (2020-07-24 19:47:37) > On Fri, Jul 24, 2020 at 05:34:11PM +0100, Chris Wilson wrote: > >Quoting Umesh Nerlige Ramappa (2020-07-24 17:29:56) > >> On Fri, Jul 24, 2020 at 01:42:33PM +0100, Chris Wilson wrote: > >> >Quoting Umesh Nerlige Ramappa (2020-07-24 01:19:01) >

Re: [Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-24 Thread Umesh Nerlige Ramappa
On Fri, Jul 24, 2020 at 05:34:11PM +0100, Chris Wilson wrote: Quoting Umesh Nerlige Ramappa (2020-07-24 17:29:56) On Fri, Jul 24, 2020 at 01:42:33PM +0100, Chris Wilson wrote: >Quoting Umesh Nerlige Ramappa (2020-07-24 01:19:01) >> From: Piotr Maciejewski >> >> i915 used to support time based

Re: [Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-24 Thread Chris Wilson
Quoting Umesh Nerlige Ramappa (2020-07-24 17:29:56) > On Fri, Jul 24, 2020 at 01:42:33PM +0100, Chris Wilson wrote: > >Quoting Umesh Nerlige Ramappa (2020-07-24 01:19:01) > >> From: Piotr Maciejewski > >> > >> i915 used to support time based sampling mode which is good for overall > >> system

Re: [Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-24 Thread Umesh Nerlige Ramappa
On Fri, Jul 24, 2020 at 01:42:33PM +0100, Chris Wilson wrote: Quoting Umesh Nerlige Ramappa (2020-07-24 01:19:01) From: Piotr Maciejewski i915 used to support time based sampling mode which is good for overall system monitoring, but is not enough for query mode used to measure a single draw

Re: [Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-24 Thread Chris Wilson
Quoting Umesh Nerlige Ramappa (2020-07-24 01:19:01) > From: Piotr Maciejewski > > i915 used to support time based sampling mode which is good for overall > system monitoring, but is not enough for query mode used to measure a > single draw call or dispatch. Gen9-Gen11 are using current i915 perf

[Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-23 Thread Umesh Nerlige Ramappa
From: Piotr Maciejewski i915 used to support time based sampling mode which is good for overall system monitoring, but is not enough for query mode used to measure a single draw call or dispatch. Gen9-Gen11 are using current i915 perf implementation for query, but Gen12+ requires a new approach

Re: [Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-23 Thread Umesh Nerlige Ramappa
On Thu, Jul 23, 2020 at 12:31:30PM +0300, Lionel Landwerlin wrote: On 22/07/2020 08:55, Umesh Nerlige Ramappa wrote: From: Piotr Maciejewski i915 used to support time based sampling mode which is good for overall system monitoring, but is not enough for query mode used to measure a single

Re: [Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-23 Thread Lionel Landwerlin
On 22/07/2020 08:55, Umesh Nerlige Ramappa wrote: From: Piotr Maciejewski i915 used to support time based sampling mode which is good for overall system monitoring, but is not enough for query mode used to measure a single draw call or dispatch. Gen9-Gen11 are using current i915 perf

[Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-21 Thread Umesh Nerlige Ramappa
From: Piotr Maciejewski i915 used to support time based sampling mode which is good for overall system monitoring, but is not enough for query mode used to measure a single draw call or dispatch. Gen9-Gen11 are using current i915 perf implementation for query, but Gen12+ requires a new approach

Re: [Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-21 Thread Chris Wilson
Quoting Umesh Nerlige Ramappa (2020-07-21 03:17:59) > Hi Chris, > > I have added your comments, but I have a few questions below: > > Thanks for your help, > Umesh > > On Mon, Jul 20, 2020 at 07:00:12PM -0700, Umesh Nerlige Ramappa wrote: > >From: Piotr Maciejewski > >+static void

Re: [Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-20 Thread Umesh Nerlige Ramappa
Hi Chris, I have added your comments, but I have a few questions below: Thanks for your help, Umesh On Mon, Jul 20, 2020 at 07:00:12PM -0700, Umesh Nerlige Ramappa wrote: From: Piotr Maciejewski i915 used to support time based sampling mode which is good for overall system monitoring, but

[Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-20 Thread Umesh Nerlige Ramappa
From: Piotr Maciejewski i915 used to support time based sampling mode which is good for overall system monitoring, but is not enough for query mode used to measure a single draw call or dispatch. Gen9-Gen11 are using current i915 perf implementation for query, but Gen12+ requires a new approach

Re: [Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-20 Thread Chris Wilson
Quoting Umesh Nerlige Ramappa (2020-07-18 01:04:37) > +static vm_fault_t vm_fault_oa(struct vm_fault *vmf) > +{ > + struct vm_area_struct *vma = vmf->vma; > + struct i915_perf_stream *stream = vma->vm_private_data; > + struct drm_i915_gem_object *obj = stream->oa_buffer.vma->obj;

Re: [Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-18 Thread kernel test robot
Hi Umesh, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip next-20200717] [cannot apply to linus/master v5.8-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And

[Intel-gfx] [PATCH 4/4] drm/i915/perf: Map OA buffer to user space for gen12 performance query

2020-07-17 Thread Umesh Nerlige Ramappa
From: Piotr Maciejewski i915 used to support time based sampling mode which is good for overall system monitoring, but is not enough for query mode used to measure a single draw call or dispatch. Gen9-Gen11 are using current i915 perf implementation for query, but Gen12+ requires a new approach