Re: [Intel-gfx] [PATCH 4/4] drm/i915: Move scanline_offset and timestamping constant setup to intel_modeset_readout_hw_state()

2015-09-23 Thread Daniel Vetter
On Mon, Sep 14, 2015 at 02:04:31PM +0200, Patrik Jakobsson wrote: > On Thu, Sep 10, 2015 at 06:59:10PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > intel_modeset_readout_hw_state() seems like the more appropriate place > > for

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Move scanline_offset and timestamping constant setup to intel_modeset_readout_hw_state()

2015-09-21 Thread Maarten Lankhorst
Hey, Op 14-09-15 om 16:23 schreef Ville Syrjälä: > On Mon, Sep 14, 2015 at 01:57:45PM +0200, Maarten Lankhorst wrote: >> Op 10-09-15 om 17:59 schreef ville.syrj...@linux.intel.com: >>> From: Ville Syrjälä >>> >>> intel_modeset_readout_hw_state() seems like the more

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Move scanline_offset and timestamping constant setup to intel_modeset_readout_hw_state()

2015-09-14 Thread Maarten Lankhorst
Op 10-09-15 om 17:59 schreef ville.syrj...@linux.intel.com: > From: Ville Syrjälä > > intel_modeset_readout_hw_state() seems like the more appropriate place > for populating the scanline_offset and timestamping constants than > intel_sanitize_crtc() since they are

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Move scanline_offset and timestamping constant setup to intel_modeset_readout_hw_state()

2015-09-14 Thread Patrik Jakobsson
On Thu, Sep 10, 2015 at 06:59:10PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > intel_modeset_readout_hw_state() seems like the more appropriate place > for populating the scanline_offset and timestamping constants than >

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Move scanline_offset and timestamping constant setup to intel_modeset_readout_hw_state()

2015-09-14 Thread Ville Syrjälä
On Mon, Sep 14, 2015 at 01:57:45PM +0200, Maarten Lankhorst wrote: > Op 10-09-15 om 17:59 schreef ville.syrj...@linux.intel.com: > > From: Ville Syrjälä > > > > intel_modeset_readout_hw_state() seems like the more appropriate place > > for populating the

[Intel-gfx] [PATCH 4/4] drm/i915: Move scanline_offset and timestamping constant setup to intel_modeset_readout_hw_state()

2015-09-10 Thread ville . syrjala
From: Ville Syrjälä intel_modeset_readout_hw_state() seems like the more appropriate place for populating the scanline_offset and timestamping constants than intel_sanitize_crtc() since they are basically part of the state we read out. Cc: Maarten Lankhorst