Re: [Intel-gfx] [PATCH 4/8] drm/i915: simplify setting DSPCNTR inside ironlake_crtc_mode_set

2012-09-12 Thread Daniel Vetter
On Wed, Sep 12, 2012 at 10:06:32AM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > Because declaring a variable in the beginning of the function, then > initializing it 100 lines later, then using it 100 lines later does > not make our code look good IMHO. > > Signed-off-by: Paulo Zanoni Qu

[Intel-gfx] [PATCH 4/8] drm/i915: simplify setting DSPCNTR inside ironlake_crtc_mode_set

2012-09-12 Thread Paulo Zanoni
From: Paulo Zanoni Because declaring a variable in the beginning of the function, then initializing it 100 lines later, then using it 100 lines later does not make our code look good IMHO. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_display.c |8 +++- 1 file changed, 3 i