Re: [Intel-gfx] [PATCH 4/9] drm/i915: Make clear/insert vfuncs args absolute

2014-02-20 Thread Ben Widawsky
On Thu, Feb 20, 2014 at 12:37:19PM +0200, Imre Deak wrote: > On Wed, 2014-02-19 at 22:05 -0800, Ben Widawsky wrote: > > This patch converts insert_entries and clear_range, both functions which > > are specific to the VM. These functions tend to encapsulate the gen > > specific PTE writes. Passing a

Re: [Intel-gfx] [PATCH 4/9] drm/i915: Make clear/insert vfuncs args absolute

2014-02-20 Thread Imre Deak
On Wed, 2014-02-19 at 22:05 -0800, Ben Widawsky wrote: > This patch converts insert_entries and clear_range, both functions which > are specific to the VM. These functions tend to encapsulate the gen > specific PTE writes. Passing absolute addresses to the insert_entries, > and clear_range will hel

[Intel-gfx] [PATCH 4/9] drm/i915: Make clear/insert vfuncs args absolute

2014-02-19 Thread Ben Widawsky
This patch converts insert_entries and clear_range, both functions which are specific to the VM. These functions tend to encapsulate the gen specific PTE writes. Passing absolute addresses to the insert_entries, and clear_range will help make the logic clearer within the functions as to what's goin

Re: [Intel-gfx] [PATCH 4/9] drm/i915: Make clear/insert vfuncs args absolute

2014-02-19 Thread Imre Deak
On Wed, 2014-02-12 at 14:28 -0800, Ben Widawsky wrote: > This patch converts insert_entries and clear_range, both functions which > are specific to the VM. These functions tend to encapsulate the gen > specific PTE writes. Passing absolute addresses to the insert_entries, > and clear_range will hel

Re: [Intel-gfx] [PATCH 4/9] drm/i915: Make clear/insert vfuncs args absolute

2014-02-12 Thread Ben Widawsky
On Thu, Feb 13, 2014 at 12:14:15AM +, Chris Wilson wrote: > On Wed, Feb 12, 2014 at 02:28:47PM -0800, Ben Widawsky wrote: > > This patch converts insert_entries and clear_range, both functions which > > are specific to the VM. These functions tend to encapsulate the gen > > specific PTE writes.

Re: [Intel-gfx] [PATCH 4/9] drm/i915: Make clear/insert vfuncs args absolute

2014-02-12 Thread Chris Wilson
On Wed, Feb 12, 2014 at 02:28:47PM -0800, Ben Widawsky wrote: > This patch converts insert_entries and clear_range, both functions which > are specific to the VM. These functions tend to encapsulate the gen > specific PTE writes. Passing absolute addresses to the insert_entries, > and clear_range w

[Intel-gfx] [PATCH 4/9] drm/i915: Make clear/insert vfuncs args absolute

2014-02-12 Thread Ben Widawsky
This patch converts insert_entries and clear_range, both functions which are specific to the VM. These functions tend to encapsulate the gen specific PTE writes. Passing absolute addresses to the insert_entries, and clear_range will help make the logic clearer within the functions as to what's goin