Re: [Intel-gfx] [PATCH 5/5] drm/i915/uc: Simplify fw_path

2017-02-15 Thread Arkadiusz Hiler
On Tue, Feb 14, 2017 at 09:23:33PM +0100, Michal Wajdeczko wrote: > On Tue, Feb 14, 2017 at 05:15:41PM +0100, Arkadiusz Hiler wrote: > > Currently fw_path values can represent one of three possible states: > > > > 1) NULL - device without the uC > > 2) '\0' - device with the uC but have no firmw

Re: [Intel-gfx] [PATCH 5/5] drm/i915/uc: Simplify fw_path

2017-02-14 Thread Michal Wajdeczko
On Tue, Feb 14, 2017 at 05:15:41PM +0100, Arkadiusz Hiler wrote: > Currently fw_path values can represent one of three possible states: > > 1) NULL - device without the uC > 2) '\0' - device with the uC but have no firmware > 3) else - device with the uC and we have firmware > > Second case is

[Intel-gfx] [PATCH 5/5] drm/i915/uc: Simplify fw_path

2017-02-14 Thread Arkadiusz Hiler
Currently fw_path values can represent one of three possible states: 1) NULL - device without the uC 2) '\0' - device with the uC but have no firmware 3) else - device with the uC and we have firmware Second case is used only to WARN at a later stage. We can WARN right away and merge cases 1