Re: [Intel-gfx] [PATCH 5/5] drm/i915: Allow vblank interrupts during modeset and eliminate some vblank races

2014-05-29 Thread Daniel Vetter
On Thu, May 29, 2014 at 6:11 AM, Michel Dänzer mic...@daenzer.net wrote: We could rename the off/on to pre/post_modeset if you like, but then someone gets to audit all the other drivers. That someone isn't going to be me. I appreciate your caution wrt other drivers, but I'm worried that

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Allow vblank interrupts during modeset and eliminate some vblank races

2014-05-29 Thread Michel Dänzer
On 29.05.2014 19:56, Daniel Vetter wrote: On Thu, May 29, 2014 at 6:11 AM, Michel Dänzer mic...@daenzer.net wrote: We could rename the off/on to pre/post_modeset if you like, but then someone gets to audit all the other drivers. That someone isn't going to be me. I appreciate your caution

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Allow vblank interrupts during modeset and eliminate some vblank races

2014-05-28 Thread Michel Dänzer
Digging out an ooold post of Daniel's... On 04.03.2014 18:13, Daniel Vetter wrote: On Tue, Feb 25, 2014 at 11:58:26AM +0900, Michel Dänzer wrote: When the pre/post-modeset hooks were originally added, it worked like this: the pre-modeset hook enabled the vblank interrupt, which updated the

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Allow vblank interrupts during modeset and eliminate some vblank races

2014-05-28 Thread Ville Syrjälä
On Wed, May 28, 2014 at 06:12:54PM +0900, Michel Dänzer wrote: Digging out an ooold post of Daniel's... On 04.03.2014 18:13, Daniel Vetter wrote: On Tue, Feb 25, 2014 at 11:58:26AM +0900, Michel Dänzer wrote: When the pre/post-modeset hooks were originally added, it worked like

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Allow vblank interrupts during modeset and eliminate some vblank races

2014-05-28 Thread Michel Dänzer
On 28.05.2014 20:19, Ville Syrjälä wrote: On Wed, May 28, 2014 at 06:12:54PM +0900, Michel Dänzer wrote: Digging out an ooold post of Daniel's... On 04.03.2014 18:13, Daniel Vetter wrote: On Tue, Feb 25, 2014 at 11:58:26AM +0900, Michel Dänzer wrote: When the pre/post-modeset hooks were

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Allow vblank interrupts during modeset and eliminate some vblank races

2014-03-04 Thread Daniel Vetter
On Tue, Feb 25, 2014 at 11:58:26AM +0900, Michel Dänzer wrote: On Mon, 2014-02-24 at 14:11 +0200, Ville Syrjälä wrote: On Mon, Feb 24, 2014 at 12:48:55PM +0900, Michel Dänzer wrote: On Fre, 2014-02-21 at 21:03 +0200, ville.syrj...@linux.intel.com wrote: We can kill of the

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Allow vblank interrupts during modeset and eliminate some vblank races

2014-03-04 Thread Daniel Vetter
On Fri, Feb 28, 2014 at 10:56:20AM +0200, Ville Syrjälä wrote: On Fri, Feb 21, 2014 at 09:03:35PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Tell the drm core vblank code to reject drm_vblank_get()s only between drm_vblank_off() and

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Allow vblank interrupts during modeset and eliminate some vblank races

2014-02-28 Thread Ville Syrjälä
On Fri, Feb 21, 2014 at 09:03:35PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Tell the drm core vblank code to reject drm_vblank_get()s only between drm_vblank_off() and drm_vblank_on() calls, and sprinkle the appropriate drm_vblank_on()

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Allow vblank interrupts during modeset and eliminate some vblank races

2014-02-26 Thread Jesse Barnes
On Tue, 25 Feb 2014 11:58:26 +0900 Michel Dänzer mic...@daenzer.net wrote: On Mon, 2014-02-24 at 14:11 +0200, Ville Syrjälä wrote: On Mon, Feb 24, 2014 at 12:48:55PM +0900, Michel Dänzer wrote: On Fre, 2014-02-21 at 21:03 +0200, ville.syrj...@linux.intel.com wrote: We can kill of

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Allow vblank interrupts during modeset and eliminate some vblank races

2014-02-24 Thread Ville Syrjälä
On Mon, Feb 24, 2014 at 12:48:55PM +0900, Michel Dänzer wrote: On Fre, 2014-02-21 at 21:03 +0200, ville.syrj...@linux.intel.com wrote: We can kill of the drm_vblank_{pre,post}_modeset() calls since those are there simply to make drm_vblank_get() fail during a modeset. Actually, their

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Allow vblank interrupts during modeset and eliminate some vblank races

2014-02-24 Thread Michel Dänzer
On Mon, 2014-02-24 at 14:11 +0200, Ville Syrjälä wrote: On Mon, Feb 24, 2014 at 12:48:55PM +0900, Michel Dänzer wrote: On Fre, 2014-02-21 at 21:03 +0200, ville.syrj...@linux.intel.com wrote: We can kill of the drm_vblank_{pre,post}_modeset() calls since those are there simply to make

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Allow vblank interrupts during modeset and eliminate some vblank races

2014-02-23 Thread Michel Dänzer
On Fre, 2014-02-21 at 21:03 +0200, ville.syrj...@linux.intel.com wrote: We can kill of the drm_vblank_{pre,post}_modeset() calls since those are there simply to make drm_vblank_get() fail during a modeset. Actually, their original purpose was to keep the DRM vblank counter consistent across

[Intel-gfx] [PATCH 5/5] drm/i915: Allow vblank interrupts during modeset and eliminate some vblank races

2014-02-21 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com Tell the drm core vblank code to reject drm_vblank_get()s only between drm_vblank_off() and drm_vblank_on() calls, and sprinkle the appropriate drm_vblank_on() calls to the .crtc_enable() hooks. At this time I kept the off calls in their current