Re: [Intel-gfx] [PATCH 5/5] drm/i915: Don't check tc_mode unless dealing with a TC PHY

2021-01-29 Thread Imre Deak
On Thu, Jan 28, 2021 at 05:59:48PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > We shouldn't really trust tc_mode on non-TC PHYs since we never > initialize it explicitly. So let's check for the PHY type first. > Fortunately TC_PORT_TBT_ALT happens to be zero so I don't think > there's a

[Intel-gfx] [PATCH 5/5] drm/i915: Don't check tc_mode unless dealing with a TC PHY

2021-01-28 Thread Ville Syrjala
From: Ville Syrjälä We shouldn't really trust tc_mode on non-TC PHYs since we never initialize it explicitly. So let's check for the PHY type first. Fortunately TC_PORT_TBT_ALT happens to be zero so I don't think there's an actual bug here, just a possibility for a future one if someone rearrange