Re: [Intel-gfx] [PATCH 5/5] drm/i915: Fix error capture on BYT/BDW

2014-01-27 Thread Ben Widawsky
On Mon, Jan 27, 2014 at 09:31:04PM +, Chris Wilson wrote: > On Mon, Jan 27, 2014 at 12:31:08PM -0800, Ben Widawsky wrote: > > The other issue is the existing method doesn't rely as much on proper > > request handling, ie. this could be more resilient to driver bugs. I > > kind of want to keep b

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Fix error capture on BYT/BDW

2014-01-27 Thread Chris Wilson
On Mon, Jan 27, 2014 at 12:31:08PM -0800, Ben Widawsky wrote: > The other issue is the existing method doesn't rely as much on proper > request handling, ie. this could be more resilient to driver bugs. I > kind of want to keep both... Actually I think it is. Part of the process of reading an erro

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Fix error capture on BYT/BDW

2014-01-27 Thread Ben Widawsky
On Mon, Jan 27, 2014 at 01:45:22PM +, Chris Wilson wrote: > On Sun, Jan 26, 2014 at 01:47:29PM -0800, Ben Widawsky wrote: > > On Sun, Jan 26, 2014 at 07:55:59PM +, Chris Wilson wrote: > > > On Sun, Jan 26, 2014 at 11:05:40AM -0800, Ben Widawsky wrote: > > > > On Sun, Jan 26, 2014 at 11:47:4

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Fix error capture on BYT/BDW

2014-01-27 Thread Ben Widawsky
On Mon, Jan 27, 2014 at 01:45:22PM +, Chris Wilson wrote: > On Sun, Jan 26, 2014 at 01:47:29PM -0800, Ben Widawsky wrote: > > On Sun, Jan 26, 2014 at 07:55:59PM +, Chris Wilson wrote: > > > On Sun, Jan 26, 2014 at 11:05:40AM -0800, Ben Widawsky wrote: > > > > On Sun, Jan 26, 2014 at 11:47:4

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Fix error capture on BYT/BDW

2014-01-27 Thread Chris Wilson
On Sun, Jan 26, 2014 at 01:47:29PM -0800, Ben Widawsky wrote: > On Sun, Jan 26, 2014 at 07:55:59PM +, Chris Wilson wrote: > > On Sun, Jan 26, 2014 at 11:05:40AM -0800, Ben Widawsky wrote: > > > On Sun, Jan 26, 2014 at 11:47:40AM +, Chris Wilson wrote: > > > > On Fri, Jan 24, 2014 at 06:17:4

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Fix error capture on BYT/BDW

2014-01-26 Thread Ben Widawsky
On Sun, Jan 26, 2014 at 07:55:59PM +, Chris Wilson wrote: > On Sun, Jan 26, 2014 at 11:05:40AM -0800, Ben Widawsky wrote: > > On Sun, Jan 26, 2014 at 11:47:40AM +, Chris Wilson wrote: > > > On Fri, Jan 24, 2014 at 06:17:45PM -0800, Ben Widawsky wrote: > > > > The previous check during error

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Fix error capture on BYT/BDW

2014-01-26 Thread Chris Wilson
On Sun, Jan 26, 2014 at 11:05:40AM -0800, Ben Widawsky wrote: > On Sun, Jan 26, 2014 at 11:47:40AM +, Chris Wilson wrote: > > On Fri, Jan 24, 2014 at 06:17:45PM -0800, Ben Widawsky wrote: > > > The previous check during error capture of whether or not the current VM > > > should be scanned used

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Fix error capture on BYT/BDW

2014-01-26 Thread Ben Widawsky
On Sun, Jan 26, 2014 at 11:47:40AM +, Chris Wilson wrote: > On Fri, Jan 24, 2014 at 06:17:45PM -0800, Ben Widawsky wrote: > > The previous check during error capture of whether or not the current VM > > should be scanned used, gen < 7. That was more or less trying to > > determine if there was

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Fix error capture on BYT/BDW

2014-01-26 Thread Chris Wilson
On Fri, Jan 24, 2014 at 06:17:45PM -0800, Ben Widawsky wrote: > The previous check during error capture of whether or not the current VM > should be scanned used, gen < 7. That was more or less trying to > determine if there was a full PPGTT. At the time, this was sort of what > I meant to do becau

[Intel-gfx] [PATCH 5/5] drm/i915: Fix error capture on BYT/BDW

2014-01-24 Thread Ben Widawsky
The previous check during error capture of whether or not the current VM should be scanned used, gen < 7. That was more or less trying to determine if there was a full PPGTT. At the time, this was sort of what I meant to do because I was more interested in working backwards from hardware state. How