Re: [Intel-gfx] [PATCH 5/5] drm/i915: Remove BUG_ON call in vlv_enable_pll

2015-12-10 Thread Daniel Vetter
On Tue, Dec 08, 2015 at 01:48:23PM +0200, Ville Syrjälä wrote: > On Mon, Dec 07, 2015 at 03:02:42PM -0800, Wayne Boyer wrote: > > Do some further clean up based on the initial review of > > drm/i915: Separate cherryview from valleyview. > > > > In this case remove the BUG_ON call in vlv_enable_pll

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Remove BUG_ON call in vlv_enable_pll

2015-12-08 Thread Ville Syrjälä
On Mon, Dec 07, 2015 at 03:02:42PM -0800, Wayne Boyer wrote: > Do some further clean up based on the initial review of > drm/i915: Separate cherryview from valleyview. > > In this case remove the BUG_ON call in vlv_enable_pll(). > > v2: Also remove the BUG_ON call in chv_enable_pll(). (Ville) >

[Intel-gfx] [PATCH 5/5] drm/i915: Remove BUG_ON call in vlv_enable_pll

2015-12-07 Thread Wayne Boyer
Do some further clean up based on the initial review of drm/i915: Separate cherryview from valleyview. In this case remove the BUG_ON call in vlv_enable_pll(). v2: Also remove the BUG_ON call in chv_enable_pll(). (Ville) Cc: Ville Syrjälä Cc: Rodrigo Vivi Signed-off-by: Wayne Boyer --- drive

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Remove BUG_ON call in vlv_enable_pll

2015-12-07 Thread Ville Syrjälä
On Mon, Dec 07, 2015 at 09:29:32PM +0200, Ville Syrjälä wrote: > On Mon, Dec 07, 2015 at 10:51:10AM -0800, Wayne Boyer wrote: > > Do some further clean up based on the initial review of > > drm/i915: Separate cherryview from valleyview. > > > > In this case remove the BUG_ON call in vlv_enable_pll

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Remove BUG_ON call in vlv_enable_pll

2015-12-07 Thread Ville Syrjälä
On Mon, Dec 07, 2015 at 10:51:10AM -0800, Wayne Boyer wrote: > Do some further clean up based on the initial review of > drm/i915: Separate cherryview from valleyview. > > In this case remove the BUG_ON call in vlv_enable_pll(). Yeah, BUG_ONs aren't very nice. Reviewed-by: Ville Syrjälä > > C

[Intel-gfx] [PATCH 5/5] drm/i915: Remove BUG_ON call in vlv_enable_pll

2015-12-07 Thread Wayne Boyer
Do some further clean up based on the initial review of drm/i915: Separate cherryview from valleyview. In this case remove the BUG_ON call in vlv_enable_pll(). Cc: Ville Syrjälä Cc: Rodrigo Vivi Signed-off-by: Wayne Boyer --- drivers/gpu/drm/i915/intel_display.c | 3 --- 1 file changed, 3 del