Re: [Intel-gfx] [PATCH 5/6] drm/i915/tc/icl: Implement the TC cold exit sequence

On Fri, 2020-03-20 at 16:11 +0300, Dan Carpenter wrote: > Hi "José, > > Thank you for the patch! Perhaps something to improve: > > url: > https://github.com/0day-ci/linux/commits/Jos-Roberto-de-Souza/drm-i915-tc-tgl-Implement-TCCOLD-sequences/20200319-080253 > base:

Re: [Intel-gfx] [PATCH 5/6] drm/i915/tc/icl: Implement the TC cold exit sequence

Hi "José, Thank you for the patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Jos-Roberto-de-Souza/drm-i915-tc-tgl-Implement-TCCOLD-sequences/20200319-080253 base: git://anongit.freedesktop.org/drm-intel for-linux-next If you fix the issue, kindly add

[Intel-gfx] [PATCH 5/6] drm/i915/tc/icl: Implement the TC cold exit sequence

This is required for legacy/static TC ports as IOM is not aware of the connection and will not trigger the TC cold exit. Just request PCODE to exit TCCOLD is not enough as it could enter again be driver makes use of the port, to prevent it BSpec states that aux powerwell should be held. So