Re: [Intel-gfx] [PATCH 5/7] drm/i915: drop redundant vblank waits

2013-04-12 Thread Chris Wilson
On Thu, Apr 11, 2013 at 04:29:08PM +0200, Daniel Vetter wrote: > Just blows through 50ms for naught, since the pipe is off. > > Signed-off-by: Daniel Vetter Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Int

Re: [Intel-gfx] [PATCH 5/7] drm/i915: drop redundant vblank waits

2013-04-11 Thread Daniel Vetter
On Thu, Apr 11, 2013 at 02:47:05PM -0300, Paulo Zanoni wrote: > Hi > > 2013/4/11 Daniel Vetter : > > Just blows through 50ms for naught, since the pipe is off. > > > > Signed-off-by: Daniel Vetter > > Looks correct, but can you also please add some WARNs in case the pipe > is actually on? Check

Re: [Intel-gfx] [PATCH 5/7] drm/i915: drop redundant vblank waits

2013-04-11 Thread Paulo Zanoni
Hi 2013/4/11 Daniel Vetter : > Just blows through 50ms for naught, since the pipe is off. > > Signed-off-by: Daniel Vetter Looks correct, but can you also please add some WARNs in case the pipe is actually on? Check haswell_crtc_mode_set for examples: - WARN_ON(I915_READ(PIPECONF(intel_crtc->cp

[Intel-gfx] [PATCH 5/7] drm/i915: drop redundant vblank waits

2013-04-11 Thread Daniel Vetter
Just blows through 50ms for naught, since the pipe is off. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_display.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 4f9f846..e91e01c 100644 --