Re: [Intel-gfx] [PATCH 5/9] drm/i915: Split skl+ plane update into noarm+arm pair

2021-11-03 Thread Lisovskiy, Stanislav
On Mon, Oct 18, 2021 at 02:50:26PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Chop skl_program_plane() into two halves. Fist half becomes > the _noarm() variant, second part the _arm() variant. > > Fortunately I have already previously grouped the register > writes into roughtly the c

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Split skl+ plane update into noarm+arm pair

2021-10-28 Thread Lisovskiy, Stanislav
On Thu, Oct 28, 2021 at 04:59:28PM +0300, Ville Syrjälä wrote: > On Thu, Oct 28, 2021 at 04:54:19PM +0300, Lisovskiy, Stanislav wrote: > > On Thu, Oct 28, 2021 at 04:03:32PM +0300, Ville Syrjälä wrote: > > > On Wed, Oct 27, 2021 at 08:11:37PM +0300, Lisovskiy, Stanislav wrote: > > > > On Mon, Oct 1

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Split skl+ plane update into noarm+arm pair

2021-10-28 Thread Ville Syrjälä
On Thu, Oct 28, 2021 at 04:54:19PM +0300, Lisovskiy, Stanislav wrote: > On Thu, Oct 28, 2021 at 04:03:32PM +0300, Ville Syrjälä wrote: > > On Wed, Oct 27, 2021 at 08:11:37PM +0300, Lisovskiy, Stanislav wrote: > > > On Mon, Oct 18, 2021 at 02:50:26PM +0300, Ville Syrjala wrote: > > > > From: Ville S

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Split skl+ plane update into noarm+arm pair

2021-10-28 Thread Lisovskiy, Stanislav
On Thu, Oct 28, 2021 at 04:03:32PM +0300, Ville Syrjälä wrote: > On Wed, Oct 27, 2021 at 08:11:37PM +0300, Lisovskiy, Stanislav wrote: > > On Mon, Oct 18, 2021 at 02:50:26PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Chop skl_program_plane() into two halves. Fist half becom

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Split skl+ plane update into noarm+arm pair

2021-10-28 Thread Ville Syrjälä
On Wed, Oct 27, 2021 at 08:11:37PM +0300, Lisovskiy, Stanislav wrote: > On Mon, Oct 18, 2021 at 02:50:26PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Chop skl_program_plane() into two halves. Fist half becomes > > the _noarm() variant, second part the _arm() variant. > > > > For

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Split skl+ plane update into noarm+arm pair

2021-10-27 Thread Lisovskiy, Stanislav
On Mon, Oct 18, 2021 at 02:50:26PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Chop skl_program_plane() into two halves. Fist half becomes > the _noarm() variant, second part the _arm() variant. > > Fortunately I have already previously grouped the register > writes into roughtly the c

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Split skl+ plane update into noarm+arm pair

2021-10-18 Thread Ville Syrjälä
On Mon, Oct 18, 2021 at 08:14:04PM +0300, Ville Syrjälä wrote: > On Mon, Oct 18, 2021 at 03:06:34PM +0300, Lisovskiy, Stanislav wrote: > > On Mon, Oct 18, 2021 at 02:50:26PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Chop skl_program_plane() into two halves. Fist half becom

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Split skl+ plane update into noarm+arm pair

2021-10-18 Thread Ville Syrjälä
On Mon, Oct 18, 2021 at 03:06:34PM +0300, Lisovskiy, Stanislav wrote: > On Mon, Oct 18, 2021 at 02:50:26PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Chop skl_program_plane() into two halves. Fist half becomes > > the _noarm() variant, second part the _arm() variant. > > > > For

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Split skl+ plane update into noarm+arm pair

2021-10-18 Thread Lisovskiy, Stanislav
On Mon, Oct 18, 2021 at 02:50:26PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Chop skl_program_plane() into two halves. Fist half becomes > the _noarm() variant, second part the _arm() variant. > > Fortunately I have already previously grouped the register > writes into roughtly the c

[Intel-gfx] [PATCH 5/9] drm/i915: Split skl+ plane update into noarm+arm pair

2021-10-18 Thread Ville Syrjala
From: Ville Syrjälä Chop skl_program_plane() into two halves. Fist half becomes the _noarm() variant, second part the _arm() variant. Fortunately I have already previously grouped the register writes into roughtly the correct order, so the split looks surprisingly clean. A few notable oddities