Re: [Intel-gfx] [PATCH 51/59] drm/i915: Add *_ring_begin() to request allocation

2015-03-31 Thread Tomas Elf
On 19/03/2015 12:30, john.c.harri...@intel.com wrote: From: John Harrison john.c.harri...@intel.com Now that the *_ring_begin() functions no longer call the request allocation code, it is finally safe for the request allocation code to call *_ring_begin(). This is important to guarantee that

Re: [Intel-gfx] [PATCH 51/59] drm/i915: Add *_ring_begin() to request allocation

2015-03-23 Thread Daniel Vetter
On Fri, Mar 20, 2015 at 04:09:55PM +, John Harrison wrote: On 20/03/2015 15:30, Chris Wilson wrote: On Fri, Mar 20, 2015 at 04:23:45PM +0100, Daniel Vetter wrote: On Thu, Mar 19, 2015 at 12:30:56PM +, john.c.harri...@intel.com wrote: diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c

Re: [Intel-gfx] [PATCH 51/59] drm/i915: Add *_ring_begin() to request allocation

2015-03-20 Thread Daniel Vetter
On Thu, Mar 19, 2015 at 12:30:56PM +, john.c.harri...@intel.com wrote: diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index 6f198df..c7dcabd 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.c +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c

Re: [Intel-gfx] [PATCH 51/59] drm/i915: Add *_ring_begin() to request allocation

2015-03-20 Thread Chris Wilson
On Fri, Mar 20, 2015 at 04:23:45PM +0100, Daniel Vetter wrote: On Thu, Mar 19, 2015 at 12:30:56PM +, john.c.harri...@intel.com wrote: diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index 6f198df..c7dcabd 100644 ---

Re: [Intel-gfx] [PATCH 51/59] drm/i915: Add *_ring_begin() to request allocation

2015-03-20 Thread John Harrison
On 20/03/2015 15:30, Chris Wilson wrote: On Fri, Mar 20, 2015 at 04:23:45PM +0100, Daniel Vetter wrote: On Thu, Mar 19, 2015 at 12:30:56PM +, john.c.harri...@intel.com wrote: diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index

[Intel-gfx] [PATCH 51/59] drm/i915: Add *_ring_begin() to request allocation

2015-03-19 Thread John . C . Harrison
From: John Harrison john.c.harri...@intel.com Now that the *_ring_begin() functions no longer call the request allocation code, it is finally safe for the request allocation code to call *_ring_begin(). This is important to guarantee that the space reserved for the subsequent i915_add_request()