Re: [Intel-gfx] [PATCH 55/59] drm/i915: Remove fallback poll for ring buffer space

2015-04-01 Thread Daniel Vetter
On Tue, Mar 31, 2015 at 07:13:40PM +0100, Tomas Elf wrote: On 19/03/2015 12:31, john.c.harri...@intel.com wrote: From: John Harrison john.c.harri...@intel.com @@ -652,8 +653,11 @@ static int logical_ring_wait_request(struct intel_ringbuffer *ringbuf, break; } -

Re: [Intel-gfx] [PATCH 55/59] drm/i915: Remove fallback poll for ring buffer space

2015-04-01 Thread Chris Wilson
On Tue, Mar 31, 2015 at 07:13:40PM +0100, Tomas Elf wrote: On 19/03/2015 12:31, john.c.harri...@intel.com wrote: From: John Harrison john.c.harri...@intel.com When the ring buffer is full, the driver finds an outstanding request that will free up sufficient space for the current operation

Re: [Intel-gfx] [PATCH 55/59] drm/i915: Remove fallback poll for ring buffer space

2015-03-31 Thread Tomas Elf
On 19/03/2015 12:31, john.c.harri...@intel.com wrote: From: John Harrison john.c.harri...@intel.com When the ring buffer is full, the driver finds an outstanding request that will free up sufficient space for the current operation and waits for it to complete. If no such request can be found,

[Intel-gfx] [PATCH 55/59] drm/i915: Remove fallback poll for ring buffer space

2015-03-19 Thread John . C . Harrison
From: John Harrison john.c.harri...@intel.com When the ring buffer is full, the driver finds an outstanding request that will free up sufficient space for the current operation and waits for it to complete. If no such request can be found, there is a fall back path of just polling until

Re: [Intel-gfx] [PATCH 55/59] drm/i915: Remove fallback poll for ring buffer space

2015-03-19 Thread Daniel Vetter
On Thu, Mar 19, 2015 at 04:33:12PM +, John Harrison wrote: On 19/03/2015 15:16, Jani Nikula wrote: On Thu, 19 Mar 2015, Daniel, Thomas thomas.dan...@intel.com wrote: - if (request-list == ring-request_list) + /* It should always be possible to find a suitable request! */ + if

Re: [Intel-gfx] [PATCH 55/59] drm/i915: Remove fallback poll for ring buffer space

2015-03-19 Thread Daniel, Thomas
-Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of john.c.harri...@intel.com Sent: Thursday, March 19, 2015 12:31 PM To: Intel-GFX@Lists.FreeDesktop.Org Subject: [Intel-gfx] [PATCH 55/59] drm/i915: Remove fallback poll for ring buffer

Re: [Intel-gfx] [PATCH 55/59] drm/i915: Remove fallback poll for ring buffer space

2015-03-19 Thread Jani Nikula
On Thu, 19 Mar 2015, Daniel, Thomas thomas.dan...@intel.com wrote: -if (request-list == ring-request_list) +/* It should always be possible to find a suitable request! */ +if (request-list == ring-request_list) { +WARN_ON(true); return -ENOSPC; +}

Re: [Intel-gfx] [PATCH 55/59] drm/i915: Remove fallback poll for ring buffer space

2015-03-19 Thread John Harrison
On 19/03/2015 15:16, Jani Nikula wrote: On Thu, 19 Mar 2015, Daniel, Thomas thomas.dan...@intel.com wrote: - if (request-list == ring-request_list) + /* It should always be possible to find a suitable request! */ + if (request-list == ring-request_list) { +