Re: [Intel-gfx] [PATCH 6/6] drm/i915/dp: Sanitize link common rate array lookups

2021-10-20 Thread Ville Syrjälä
On Wed, Oct 20, 2021 at 12:53:52PM +0300, Jani Nikula wrote: > On Wed, 20 Oct 2021, Imre Deak wrote: > > On Tue, Oct 19, 2021 at 10:23:14PM +0300, Jani Nikula wrote: > >> On Mon, 18 Oct 2021, Imre Deak wrote: > >> > Add an assert that lookups from the intel_dp->common_rates[] array > >> > are alw

Re: [Intel-gfx] [PATCH 6/6] drm/i915/dp: Sanitize link common rate array lookups

2021-10-20 Thread Jani Nikula
On Wed, 20 Oct 2021, Imre Deak wrote: > On Tue, Oct 19, 2021 at 10:23:14PM +0300, Jani Nikula wrote: >> On Mon, 18 Oct 2021, Imre Deak wrote: >> > Add an assert that lookups from the intel_dp->common_rates[] array >> > are always valid. >> >> The one thought I had here was that if we're adding h

Re: [Intel-gfx] [PATCH 6/6] drm/i915/dp: Sanitize link common rate array lookups

2021-10-20 Thread Imre Deak
On Tue, Oct 19, 2021 at 10:23:14PM +0300, Jani Nikula wrote: > On Mon, 18 Oct 2021, Imre Deak wrote: > > Add an assert that lookups from the intel_dp->common_rates[] array > > are always valid. > > The one thought I had here was that if we're adding helper functions for > accessing common rates,

Re: [Intel-gfx] [PATCH 6/6] drm/i915/dp: Sanitize link common rate array lookups

2021-10-19 Thread Jani Nikula
On Mon, 18 Oct 2021, Imre Deak wrote: > Add an assert that lookups from the intel_dp->common_rates[] array > are always valid. The one thought I had here was that if we're adding helper functions for accessing common rates, they should probably be of the form "this is the rate I have now, give me

[Intel-gfx] [PATCH 6/6] drm/i915/dp: Sanitize link common rate array lookups

2021-10-18 Thread Imre Deak
Add an assert that lookups from the intel_dp->common_rates[] array are always valid. Cc: Ville Syrjälä Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_dp.c | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/i915/displa