Re: [Intel-gfx] [PATCH 6/6] drm/i915/psr: Define more PSR mask bits

2023-03-21 Thread Ville Syrjälä
On Mon, Mar 20, 2023 at 11:54:38AM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Define more of the PSR mask bits. Even if we don't set them > from the driver they can be very useful during PSR debugging. > Having to trawl through bspec every time to find them is > not fun. > > The parti

Re: [Intel-gfx] [PATCH 6/6] drm/i915/psr: Define more PSR mask bits

2023-03-20 Thread Ville Syrjälä
On Mon, Mar 20, 2023 at 02:05:46PM +0200, Imre Deak wrote: > On Mon, Mar 20, 2023 at 11:54:38AM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Define more of the PSR mask bits. Even if we don't set them > > from the driver they can be very useful during PSR debugging. > > Having to t

Re: [Intel-gfx] [PATCH 6/6] drm/i915/psr: Define more PSR mask bits

2023-03-20 Thread Imre Deak
On Mon, Mar 20, 2023 at 11:54:38AM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Define more of the PSR mask bits. Even if we don't set them > from the driver they can be very useful during PSR debugging. > Having to trawl through bspec every time to find them is > not fun. > > The parti

[Intel-gfx] [PATCH 6/6] drm/i915/psr: Define more PSR mask bits

2023-03-20 Thread Ville Syrjala
From: Ville Syrjälä Define more of the PSR mask bits. Even if we don't set them from the driver they can be very useful during PSR debugging. Having to trawl through bspec every time to find them is not fun. The particularly interesting bits are: - PIPE_MISC[21]/PIPE_MISC_PSR_MASK_PIPE_REG_WRIT