Re: [Intel-gfx] [PATCH 6/6] drm/i915: Only call tasklet_kill() on the first prepare_reset

2018-03-09 Thread Chris Wilson
Quoting Chris Wilson (2018-03-09 14:10:34) > Quoting Chris Wilson (2018-03-07 13:42:26) > > tasklet_kill() will spin waiting for the current tasklet to be executed. > > However, if tasklet_disable() has been called, then the tasklet is never > > executed but permanently put back onto the runlist

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Only call tasklet_kill() on the first prepare_reset

2018-03-09 Thread Chris Wilson
Quoting Chris Wilson (2018-03-07 13:42:26) > tasklet_kill() will spin waiting for the current tasklet to be executed. > However, if tasklet_disable() has been called, then the tasklet is never > executed but permanently put back onto the runlist until > tasklet_enable() is called. Ergo, we cannot

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Only call tasklet_kill() on the first prepare_reset

2018-03-09 Thread Mika Kuoppala
Chris Wilson writes: > tasklet_kill() will spin waiting for the current tasklet to be executed. > However, if tasklet_disable() has been called, then the tasklet is never > executed but permanently put back onto the runlist until > tasklet_enable() is called. Ergo, we

[Intel-gfx] [PATCH 6/6] drm/i915: Only call tasklet_kill() on the first prepare_reset

2018-03-07 Thread Chris Wilson
tasklet_kill() will spin waiting for the current tasklet to be executed. However, if tasklet_disable() has been called, then the tasklet is never executed but permanently put back onto the runlist until tasklet_enable() is called. Ergo, we cannot use tasklet_kill() inside a disable/enable pair.