Re: [Intel-gfx] [PATCH 6/8] drm/i915: change force wake order for GT read

2011-03-22 Thread Chris Wilson
On Tue, 22 Mar 2011 09:27:51 +0800, Zhenyu Wang zhen...@linux.intel.com wrote: Just mean to follow the doc, it matches the sequence of RC6 enabling steps from GT PM programming doc, not sure if it's strictly required. But as you point out, the docs do also outline the current method as well.

[Intel-gfx] [PATCH 6/8] drm/i915: change force wake order for GT read

2011-03-21 Thread Zhenyu Wang
Move FORCEWAKE_ACK == 0 wait after setting force wake to 0. This is another way to set force wake for GT read from spec. And also this makes RC6 setting order strictly follow spec. Signed-off-by: Zhenyu Wang zhen...@linux.intel.com --- drivers/gpu/drm/i915/i915_drv.c | 11 +++ 1 files

Re: [Intel-gfx] [PATCH 6/8] drm/i915: change force wake order for GT read

2011-03-21 Thread Chris Wilson
On Mon, 21 Mar 2011 17:27:17 +0800, Zhenyu Wang zhen...@linux.intel.com wrote: Move FORCEWAKE_ACK == 0 wait after setting force wake to 0. This is another way to set force wake for GT read from spec. And also this makes RC6 setting order strictly follow spec. The spec does indeed give both

Re: [Intel-gfx] [PATCH 6/8] drm/i915: change force wake order for GT read

2011-03-21 Thread Zhenyu Wang
On 2011.03.21 09:46:20 +, Chris Wilson wrote: On Mon, 21 Mar 2011 17:27:17 +0800, Zhenyu Wang zhen...@linux.intel.com wrote: Move FORCEWAKE_ACK == 0 wait after setting force wake to 0. This is another way to set force wake for GT read from spec. And also this makes RC6 setting order