Re: [Intel-gfx] [PATCH 7/7] drm/i915: simplify config->pixel_multiplier handling

2013-04-25 Thread Daniel Vetter
On Thu, Apr 25, 2013 at 03:08:32PM +0300, Ville Syrjälä wrote: > On Fri, Apr 19, 2013 at 11:14:37AM +0200, Daniel Vetter wrote: > > We only ever check whether it's strictly bigger than one, so all the > > is_sdvo/is_hdmi checks are redundant. Flatten the code a bit. > > > > Also, s/temp/dpll_md/ >

Re: [Intel-gfx] [PATCH 7/7] drm/i915: simplify config->pixel_multiplier handling

2013-04-25 Thread Daniel Vetter
On Thu, Apr 25, 2013 at 03:08:32PM +0300, Ville Syrjälä wrote: > On Fri, Apr 19, 2013 at 11:14:37AM +0200, Daniel Vetter wrote: > > We only ever check whether it's strictly bigger than one, so all the > > is_sdvo/is_hdmi checks are redundant. Flatten the code a bit. > > > > Also, s/temp/dpll_md/ >

Re: [Intel-gfx] [PATCH 7/7] drm/i915: simplify config->pixel_multiplier handling

2013-04-25 Thread Ville Syrjälä
On Fri, Apr 19, 2013 at 11:14:37AM +0200, Daniel Vetter wrote: > We only ever check whether it's strictly bigger than one, so all the > is_sdvo/is_hdmi checks are redundant. Flatten the code a bit. > > Also, s/temp/dpll_md/ > > Signed-off-by: Daniel Vetter Looks OK. Note that we actually never

[Intel-gfx] [PATCH 7/7] drm/i915: simplify config->pixel_multiplier handling

2013-04-19 Thread Daniel Vetter
We only ever check whether it's strictly bigger than one, so all the is_sdvo/is_hdmi checks are redundant. Flatten the code a bit. Also, s/temp/dpll_md/ Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_display.c | 58 +--- 1 file changed, 27 insertions