Re: [Intel-gfx] [PATCH 7/8] drm/i915/gt: Remove direct invocation of breadcrumb signaling

2019-12-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-12-18 16:48:20) > > On 17/12/2019 09:56, Chris Wilson wrote: > > Only signal the breadcrumbs from inside the irq_work, simplifying our > > interface and calling conventions. The micro-optimisation here is that > > by always using the irq_work interface, we know we are

Re: [Intel-gfx] [PATCH 7/8] drm/i915/gt: Remove direct invocation of breadcrumb signaling

2019-12-18 Thread Tvrtko Ursulin
On 17/12/2019 09:56, Chris Wilson wrote: Only signal the breadcrumbs from inside the irq_work, simplifying our interface and calling conventions. The micro-optimisation here is that by always using the irq_work interface, we know we are always inside an irq-off critical section for the

[Intel-gfx] [PATCH 7/8] drm/i915/gt: Remove direct invocation of breadcrumb signaling

2019-12-17 Thread Chris Wilson
Only signal the breadcrumbs from inside the irq_work, simplifying our interface and calling conventions. The micro-optimisation here is that by always using the irq_work interface, we know we are always inside an irq-off critical section for the breadcrumb signaling and can ellide save/restore of