Re: [Intel-gfx] [PATCH 7/8] drm/i915: Move max voltage and pre emphasis to intel_dp_link_training.c

2015-10-19 Thread Ander Conselvan De Oliveira
On Mon, 2015-10-19 at 10:44 +0530, Thulasimani, Sivakumar wrote: > As an FYI, both of these functions need to be rewritten when we want the > code to be > compliant to DP spec. > We should read the pre-emphasis given by the panel and if vwing exeeds > max value > we should use the max vswing

Re: [Intel-gfx] [PATCH 7/8] drm/i915: Move max voltage and pre emphasis to intel_dp_link_training.c

2015-10-18 Thread Thulasimani, Sivakumar
As an FYI, both of these functions need to be rewritten when we want the code to be compliant to DP spec. We should read the pre-emphasis given by the panel and if vwing exeeds max value we should use the max vswing supported for that pre-emphasis but current code is opposite of that. you can

[Intel-gfx] [PATCH 7/8] drm/i915: Move max voltage and pre emphasis to intel_dp_link_training.c

2015-09-08 Thread Ander Conselvan de Oliveira
So link training tests can use real hardware limits. --- drivers/gpu/drm/i915/intel_dp.c | 99 --- drivers/gpu/drm/i915/intel_dp_link_training.c | 92 + drivers/gpu/drm/i915/intel_drv.h | 11 +-- 3 files changed, 99

Re: [Intel-gfx] [PATCH 7/8] drm/i915: Move max voltage and pre emphasis to intel_dp_link_training.c

2015-09-08 Thread Ville Syrjälä
On Tue, Sep 08, 2015 at 03:27:58PM +0300, Ander Conselvan de Oliveira wrote: > So link training tests can use real hardware limits. These need to be kept in sync with the _signal_levels() functions, so moving them to a separate file is a bit questionable. I suggest that we should attempt to