Re: [Intel-gfx] [PATCH 7/9] drm/i915: Simplify i915_gem_object_ggtt_unpin

2014-01-28 Thread Jani Nikula
On Mon, 27 Jan 2014, Daniel Vetter daniel.vet...@ffwll.ch wrote: Split out from Chris vma-bind rework. simplify does not explain to me *why* you can skip two checks in the code. BR, Jani. Cc: Chris Wilson ch...@chris-wilson.co.uk Cc: Ben Widawsky benjamin.widaw...@intel.com Signed-off-by:

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Simplify i915_gem_object_ggtt_unpin

2014-01-28 Thread Chris Wilson
On Tue, Jan 28, 2014 at 03:13:34PM +0200, Jani Nikula wrote: On Mon, 27 Jan 2014, Daniel Vetter daniel.vet...@ffwll.ch wrote: Split out from Chris vma-bind rework. simplify does not explain to me *why* you can skip two checks in the code. Because they are all repeated in i915_vma_unbind().

[Intel-gfx] [PATCH 7/9] drm/i915: Simplify i915_gem_object_ggtt_unpin

2014-01-27 Thread Daniel Vetter
Split out from Chris vma-bind rework. Cc: Chris Wilson ch...@chris-wilson.co.uk Cc: Ben Widawsky benjamin.widaw...@intel.com Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/i915/i915_drv.h | 10 -- drivers/gpu/drm/i915/i915_gem.c | 20 2 files