Re: [Intel-gfx] [PATCH RESEND i-g-t 2/2] kms_frontbuffer_tracking: Don't poke compressing status for old cpus

2017-05-04 Thread Petri Latvala
On Wed, Apr 26, 2017 at 03:36:16PM -0300, Paulo Zanoni wrote: > > I have a feeling I asked this before, but why aren't we just fixing > > the kernel to report it correctly? For any platform with FBC2 it > > should be trivial, > > Right, I see there's a reg for that for ILK/SNB. > > > for FBC1

Re: [Intel-gfx] [PATCH RESEND i-g-t 2/2] kms_frontbuffer_tracking: Don't poke compressing status for old cpus

2017-04-26 Thread Paulo Zanoni
Em Qua, 2017-04-26 às 21:12 +0300, Ville Syrjälä escreveu: > On Wed, Apr 26, 2017 at 02:57:49PM -0300, Gabriel Krisman Bertazi > wrote: > > > > Paulo Zanoni writes: > > > > > > > > Ouch... Good catch! > > > > > > Can you please move the logic to the setup_fbc()

Re: [Intel-gfx] [PATCH RESEND i-g-t 2/2] kms_frontbuffer_tracking: Don't poke compressing status for old cpus

2017-04-26 Thread Ville Syrjälä
On Wed, Apr 26, 2017 at 02:57:49PM -0300, Gabriel Krisman Bertazi wrote: > Paulo Zanoni writes: > > > Ouch... Good catch! > > > > Can you please move the logic to the setup_fbc() function? > > > > if (gen < 7) > > opt.fbc_check_compression = false; > > > > This way

Re: [Intel-gfx] [PATCH RESEND i-g-t 2/2] kms_frontbuffer_tracking: Don't poke compressing status for old cpus

2017-04-26 Thread Gabriel Krisman Bertazi
Paulo Zanoni writes: > Ouch... Good catch! > > Can you please move the logic to the setup_fbc() function? > > if (gen < 7) > opt.fbc_check_compression = false; > > This way we avoid redoing the same check a trillion times during > kms_frontbuffer_tracking