Re: [Intel-gfx] [PATCH V4] drm/i915/skl: SKL CDCLK change on modeset tracking VCO

2016-02-12 Thread Clint Taylor
On 02/12/2016 03:18 AM, Ville Syrjälä wrote: On Thu, Feb 11, 2016 at 03:22:08PM -0800, clinton.a.tay...@intel.com wrote: From: Clint Taylor Track VCO frequency of SKL instead of the boot CDCLK and allow modeset to set cdclk based on the max required pixel clock based on VCO selected. The vco

Re: [Intel-gfx] [PATCH V4] drm/i915/skl: SKL CDCLK change on modeset tracking VCO

2016-02-12 Thread Ville Syrjälä
On Thu, Feb 11, 2016 at 05:11:52PM -0800, Marc Herbert wrote: > [I'm cheating and doing this code review with the author watching over my > shoulder] > > On 11/02/16 15:22, clinton.a.tay...@intel.com wrote: > > From: Clint Taylor > > > > Track VCO frequency of SKL instead of the boot CDCLK and

Re: [Intel-gfx] [PATCH V4] drm/i915/skl: SKL CDCLK change on modeset tracking VCO

2016-02-12 Thread Ville Syrjälä
On Thu, Feb 11, 2016 at 03:22:08PM -0800, clinton.a.tay...@intel.com wrote: > From: Clint Taylor > > Track VCO frequency of SKL instead of the boot CDCLK and allow modeset > to set cdclk based on the max required pixel clock based on VCO > selected. > > The vco should be tracked at the atomic le

Re: [Intel-gfx] [PATCH V4] drm/i915/skl: SKL CDCLK change on modeset tracking VCO

2016-02-11 Thread Marc Herbert
[I'm cheating and doing this code review with the author watching over my shoulder] On 11/02/16 15:22, clinton.a.tay...@intel.com wrote: > From: Clint Taylor > > Track VCO frequency of SKL instead of the boot CDCLK and allow modeset > to set cdclk based on the max required pixel clock based on

[Intel-gfx] [PATCH V4] drm/i915/skl: SKL CDCLK change on modeset tracking VCO

2016-02-11 Thread clinton . a . taylor
From: Clint Taylor Track VCO frequency of SKL instead of the boot CDCLK and allow modeset to set cdclk based on the max required pixel clock based on VCO selected. The vco should be tracked at the atomic level and all CRTCs updated if the required vco is changed. At this time the eDP pll is conf