[Intel-gfx] [PATCH i-g-t] lib/igt_core: Move write_stderr out of LIBUNWIND ifdef

2017-11-24 Thread Arkadiusz Hiler
write_stderr() and __write_stderr() are defined behind ifdef on HAVE_LIBUNWIND, but do no depend on the lib in any way. fatal_sig_handler() uses those helpers unconditionally. This patch just moves the code couple of lines up, so the helpers are always available and do not break build on systems

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_core: Move write_stderr out of LIBUNWIND ifdef

2017-11-24 Thread Chris Wilson
Quoting Arkadiusz Hiler (2017-11-24 10:32:07) > write_stderr() and __write_stderr() are defined behind ifdef on > HAVE_LIBUNWIND, but do no depend on the lib in any way. Hmm, we keep getting caught out by large ifdefs. Although I guess conditionally enabled code itself is less-than-welcome, we sho

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_core: Move write_stderr out of LIBUNWIND ifdef

2017-11-24 Thread Tvrtko Ursulin
On 24/11/2017 10:32, Arkadiusz Hiler wrote: write_stderr() and __write_stderr() are defined behind ifdef on HAVE_LIBUNWIND, but do no depend on the lib in any way. fatal_sig_handler() uses those helpers unconditionally. This patch just moves the code couple of lines up, so the helpers are alwa

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_core: Move write_stderr out of LIBUNWIND ifdef

2017-11-24 Thread Arkadiusz Hiler
On Fri, Nov 24, 2017 at 10:51:38AM +, Chris Wilson wrote: > Quoting Arkadiusz Hiler (2017-11-24 10:32:07) > > write_stderr() and __write_stderr() are defined behind ifdef on > > HAVE_LIBUNWIND, but do no depend on the lib in any way. > > Hmm, we keep getting caught out by large ifdefs. Althoug