[Intel-gfx] [PATCH i-g-t 05/13] chamelium: Fix build issues on Android

2017-05-16 Thread Arkadiusz Hiler
Makefile.sources are included 1:1 in Android.mk files, and are not parsed by automake. And yet those had some automake conditional logic. Moving it to .am file is enough for now. Also igt_chamelium.h included config.h without proper "HAVE_CONFIG_H" guard, and the file itself was included unconditi

[Intel-gfx] [PATCH i-g-t 05/13] chamelium: Fix build issues on Android

2017-04-19 Thread Arkadiusz Hiler
Makefile.sources are included 1:1 in Android.mk files, and are not parsed by automake. And yet those had some automake conditional logic. Moving it to .am file is enough for now. Also igt_chamelium.h included config.h without proper "HAVE_CONFIG_H" guard, and the file itself was included unconditi

Re: [Intel-gfx] [PATCH i-g-t 05/13] chamelium: Fix build issues on Android

2017-05-05 Thread Arkadiusz Hiler
On Tue, May 02, 2017 at 12:53:16PM +0300, Petri Latvala wrote: > On Wed, Apr 19, 2017 at 01:01:47PM +0200, Arkadiusz Hiler wrote: > > Also igt_chamelium.h included config.h without proper "HAVE_CONFIG_H" > > guard, and the file itself was included unconditionally. > > I see unconditional config.h

Re: [Intel-gfx] [PATCH i-g-t 05/13] chamelium: Fix build issues on Android

2017-05-16 Thread Michal Wajdeczko
On Tue, May 16, 2017 at 03:24:54PM +0200, Arkadiusz Hiler wrote: > Makefile.sources are included 1:1 in Android.mk files, and are not > parsed by automake. And yet those had some automake conditional logic. > Moving it to .am file is enough for now. Hmm, all sources shall be listed only in Makefil

Re: [Intel-gfx] [PATCH i-g-t 05/13] chamelium: Fix build issues on Android

2017-05-02 Thread Petri Latvala
On Wed, Apr 19, 2017 at 01:01:47PM +0200, Arkadiusz Hiler wrote: > Also igt_chamelium.h included config.h without proper "HAVE_CONFIG_H" > guard, and the file itself was included unconditionally. I see unconditional config.h inclusion in several other places, is igt_chamelium.h the only file where