Re: [Intel-gfx] [PATCH i-g-t 1/1] igt/dapc: Test Driver Assisted Performance Capture (DAPC)

2017-08-30 Thread Daniel Vetter
On Wed, Aug 30, 2017 at 10:43:47AM +0100, Lionel Landwerlin wrote: > On 30/08/17 10:39, Daniel Vetter wrote: > > Also dapc is not a good testcase name, needs some proper prefixing. > > > Reminds me perf.c should probably be renamed too. > What would be an appropriate name? intel_perf.c? I think

Re: [Intel-gfx] [PATCH i-g-t 1/1] igt/dapc: Test Driver Assisted Performance Capture (DAPC)

2017-08-30 Thread Kamble, Sagar A
Thanks Lionel for the review. Will revamp the testcase. Thanks Sagar On 8/29/2017 2:21 PM, Lionel Landwerlin wrote: Hi Sagar, Thanks for writing this test. It looks promising but there are a few issues that needs to be addressed for this to run in CI. Please have a look at the comments bel

Re: [Intel-gfx] [PATCH i-g-t 1/1] igt/dapc: Test Driver Assisted Performance Capture (DAPC)

2017-08-30 Thread Kamble, Sagar A
On 8/30/2017 3:09 PM, Daniel Vetter wrote: One more on top of Lionel's coments. On Mon, Aug 28, 2017 at 03:23:03PM +0530, Sagar Arun Kamble wrote: +int main(int argc, char **argv) +{ + bool ret; + int option; + int platform; + + if (argc != 3) { + printf(

Re: [Intel-gfx] [PATCH i-g-t 1/1] igt/dapc: Test Driver Assisted Performance Capture (DAPC)

2017-08-30 Thread Lionel Landwerlin
On 30/08/17 10:39, Daniel Vetter wrote: Also dapc is not a good testcase name, needs some proper prefixing. Reminds me perf.c should probably be renamed too. What would be an appropriate name? intel_perf.c? ___ Intel-gfx mailing list Intel-gfx@lists.

Re: [Intel-gfx] [PATCH i-g-t 1/1] igt/dapc: Test Driver Assisted Performance Capture (DAPC)

2017-08-30 Thread Daniel Vetter
One more on top of Lionel's coments. On Mon, Aug 28, 2017 at 03:23:03PM +0530, Sagar Arun Kamble wrote: > +int main(int argc, char **argv) > +{ > + bool ret; > + int option; > + int platform; > + > + if (argc != 3) { > + printf("Usage: \n./dapc \ > + \nPlat

Re: [Intel-gfx] [PATCH i-g-t 1/1] igt/dapc: Test Driver Assisted Performance Capture (DAPC)

2017-08-29 Thread Lionel Landwerlin
Hi Sagar, Thanks for writing this test. It looks promising but there are a few issues that needs to be addressed for this to run in CI. Please have a look at the comments below. Thanks! On 28/08/17 10:53, Sagar Arun Kamble wrote: This test verifies different i915 perf sampling options for fi

[Intel-gfx] [PATCH i-g-t 1/1] igt/dapc: Test Driver Assisted Performance Capture (DAPC)

2017-08-28 Thread Sagar Arun Kamble
This test verifies different i915 perf sampling options for fields like PID, CTX ID, Timestamp, OA Report, TAG, MMIO. Cc: Lionel Landwerlin Signed-off-by: Sourab Gupta Signed-off-by: Sagar Arun Kamble --- tests/Makefile.sources |1 + tests/dapc.c | 1017 ++