Re: [Intel-gfx] [PATCH i-g-t 6/6] tests/i915_query: Engine queues tests

2018-06-08 Thread Lionel Landwerlin
On 08/06/18 11:02, Tvrtko Ursulin wrote: On 06/06/2018 15:33, Lionel Landwerlin wrote: Just a few suggestions below. Otherwise looks good to me. On 06/06/18 13:49, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Basic tests to cover engine queued/runnable/running metric as reported by the DRM_I9

Re: [Intel-gfx] [PATCH i-g-t 6/6] tests/i915_query: Engine queues tests

2018-06-08 Thread Tvrtko Ursulin
On 06/06/2018 15:33, Lionel Landwerlin wrote: Just a few suggestions below. Otherwise looks good to me. On 06/06/18 13:49, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Basic tests to cover engine queued/runnable/running metric as reported by the DRM_I915_QUERY_ENGINE_QUEUES query. v2:   * Upd

Re: [Intel-gfx] [PATCH i-g-t 6/6] tests/i915_query: Engine queues tests

2018-06-06 Thread Lionel Landwerlin
Just a few suggestions below. Otherwise looks good to me. On 06/06/18 13:49, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Basic tests to cover engine queued/runnable/running metric as reported by the DRM_I915_QUERY_ENGINE_QUEUES query. v2: * Update ABI for i915 changes. * Use igt_spin_busyw

[Intel-gfx] [PATCH i-g-t 6/6] tests/i915_query: Engine queues tests

2018-06-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Basic tests to cover engine queued/runnable/running metric as reported by the DRM_I915_QUERY_ENGINE_QUEUES query. v2: * Update ABI for i915 changes. * Use igt_spin_busywait_until_running. * Support no hardware contexts. * More comments. (Lionel Landwerlin) Chris Wilson: