Re: [Intel-gfx] [PATCH igt] igt/tools_test: Remove dmesg subtest

2017-09-08 Thread Daniel Vetter
On Thu, Sep 07, 2017 at 07:29:25PM +0100, Chris Wilson wrote: > It's a silly test. If fails if there is an *ERROR* in the dmesg ringbuf, > so it neither is testing that errors are generated as expected, and as a > pre-check it can only see what's at the end of the dmesg and may miss > earlier

Re: [Intel-gfx] [PATCH igt] igt/tools_test: Remove dmesg subtest

2017-09-07 Thread Chris Wilson
Quoting Chris Wilson (2017-09-07 19:29:25) > It's a silly test. If fails if there is an *ERROR* in the dmesg ringbuf, > so it neither is testing that errors are generated as expected, and as a > pre-check it can only see what's at the end of the dmesg and may miss > earlier faults. As a test it

[Intel-gfx] [PATCH igt] igt/tools_test: Remove dmesg subtest

2017-09-07 Thread Chris Wilson
It's a silly test. If fails if there is an *ERROR* in the dmesg ringbuf, so it neither is testing that errors are generated as expected, and as a pre-check it can only see what's at the end of the dmesg and may miss earlier faults. As a test it just randomly fails; worse than useless.