Re: [Intel-gfx] [PATCH libdrm v2 1/5] intel: add generic functions to check PCI ID

2018-08-31 Thread Chris Wilson
Quoting Lucas De Marchi (2018-08-31 17:06:01) > On Fri, Aug 31, 2018 at 09:16:23AM +0100, Chris Wilson wrote: > > Quoting Lucas De Marchi (2018-08-29 01:35:28) > > > +bool intel_is_genx(unsigned int devid, int gen) > > > +{ > > > + const struct pci_device *p, > > > + *pend = p

Re: [Intel-gfx] [PATCH libdrm v2 1/5] intel: add generic functions to check PCI ID

2018-08-31 Thread Lucas De Marchi
On Fri, Aug 31, 2018 at 09:16:23AM +0100, Chris Wilson wrote: > Quoting Lucas De Marchi (2018-08-29 01:35:28) > > +static const struct pci_device { > > + uint16_t device; > > + uint16_t gen; > > +} pciids[] = { > > Add a comment here as well for the ordering requirement. > > /* Keep i

Re: [Intel-gfx] [PATCH libdrm v2 1/5] intel: add generic functions to check PCI ID

2018-08-31 Thread Chris Wilson
Quoting Lucas De Marchi (2018-08-29 01:35:28) > +static const struct pci_device { > + uint16_t device; > + uint16_t gen; > +} pciids[] = { Add a comment here as well for the ordering requirement. /* Keep ids sorted by gen; latest gen first */ We're unlikely to notice a comment in the

[Intel-gfx] [PATCH libdrm v2 1/5] intel: add generic functions to check PCI ID

2018-08-28 Thread Lucas De Marchi
This will allow platforms to reuse kernel IDs instead of manually keeping them in sync. In most of the cases we only need to extend IS_9XX(). Current platforms that fit this requirement can be ported over to use this macro. Right now it's a nop since it doesn't have any PCI ID added. The i915_pci