Re: [Intel-gfx] [PATCH libdrm v2 4/5] intel: make gen9 use generic gen macro

2018-08-31 Thread Lucas De Marchi
On Fri, Aug 31, 2018 at 09:21:32AM +0100, Chris Wilson wrote: > Quoting Lucas De Marchi (2018-08-29 01:35:31) > > The 2 PCI IDs that are used for the command line overrid mechanism > > were left defined. The rest can be gone and then we just use the kernel > > defines. > > > > Signed-off-by: Lucas

Re: [Intel-gfx] [PATCH libdrm v2 4/5] intel: make gen9 use generic gen macro

2018-08-31 Thread Chris Wilson
Quoting Lucas De Marchi (2018-08-29 01:35:31) > The 2 PCI IDs that are used for the command line overrid mechanism > were left defined. The rest can be gone and then we just use the kernel > defines. > > Signed-off-by: Lucas De Marchi > --- > intel/intel_chipset.c | 5 ++ > intel/intel_chipset

Re: [Intel-gfx] [PATCH libdrm v2 4/5] intel: make gen9 use generic gen macro

2018-08-31 Thread Chris Wilson
Quoting Lucas De Marchi (2018-08-29 17:01:11) > On Wed, Aug 29, 2018 at 11:32:35AM +0100, Chris Wilson wrote: > > Quoting Lucas De Marchi (2018-08-29 01:35:31) > > > The 2 PCI IDs that are used for the command line overrid mechanism > > > were left defined. > > > > What makes them so special? Why

Re: [Intel-gfx] [PATCH libdrm v2 4/5] intel: make gen9 use generic gen macro

2018-08-29 Thread Lucas De Marchi
On Wed, Aug 29, 2018 at 11:32:35AM +0100, Chris Wilson wrote: > Quoting Lucas De Marchi (2018-08-29 01:35:31) > > The 2 PCI IDs that are used for the command line overrid mechanism > > were left defined. > > What makes them so special? Why not just match on the override devid? because it's a name

Re: [Intel-gfx] [PATCH libdrm v2 4/5] intel: make gen9 use generic gen macro

2018-08-29 Thread Chris Wilson
Quoting Lucas De Marchi (2018-08-29 01:35:31) > The 2 PCI IDs that are used for the command line overrid mechanism > were left defined. What makes them so special? Why not just match on the override devid? -Chris ___ Intel-gfx mailing list Intel-gfx@list

[Intel-gfx] [PATCH libdrm v2 4/5] intel: make gen9 use generic gen macro

2018-08-28 Thread Lucas De Marchi
The 2 PCI IDs that are used for the command line overrid mechanism were left defined. The rest can be gone and then we just use the kernel defines. Signed-off-by: Lucas De Marchi --- intel/intel_chipset.c | 5 ++ intel/intel_chipset.h | 187 +- 2 files c