Re: [Intel-gfx] [PATCH v1] drm/i915: GTT offset is cut by 32b-flag.

2018-11-02 Thread Michal Wajdeczko
On Fri, 02 Nov 2018 17:32:06 +0100, Lionel Landwerlin wrote: On 02/11/2018 15:47, Sergii Romantsov wrote: Operating with gtt-addresses has to be done with 64b variables. CC: Kenneth Graunke CC: Chris Wilson Fixes: a363bb2cd0e2 (i965: Allocate VMA in userspace for full-PPGTT systems.) Fi

Re: [Intel-gfx] [PATCH v1] drm/i915: GTT offset is cut by 32b-flag.

2018-11-02 Thread Chris Wilson
Quoting Lionel Landwerlin (2018-11-02 16:32:06) > On 02/11/2018 15:47, Sergii Romantsov wrote: > > Operating with gtt-addresses has to be done with 64b variables. > > > > CC: Kenneth Graunke > > CC: Chris Wilson > > Fixes: a363bb2cd0e2 (i965: Allocate VMA in userspace for full-PPGTT > > systems.

Re: [Intel-gfx] [PATCH v1] drm/i915: GTT offset is cut by 32b-flag.

2018-11-02 Thread Lionel Landwerlin
On 02/11/2018 15:47, Sergii Romantsov wrote: Operating with gtt-addresses has to be done with 64b variables. CC: Kenneth Graunke CC: Chris Wilson Fixes: a363bb2cd0e2 (i965: Allocate VMA in userspace for full-PPGTT systems.) Fixes: c7c6e46f913b (drm/i915: Convert execbuf to use struct-of-array

Re: [Intel-gfx] [PATCH v1] drm/i915: GTT offset is cut by 32b-flag.

2018-11-02 Thread Sergii Romantsov
Seems extending of any PIN_XXX flags to 64b has no sense for all other cases. But also in the code there is mismatching of 64 and 32b flags/data usage (32b flags may be put to 64b arguments). Seems that shouldn't cause any issues anymore, but if you think that it should be fixed - please, let me kn

[Intel-gfx] [PATCH v1] drm/i915: GTT offset is cut by 32b-flag.

2018-11-02 Thread Sergii Romantsov
Operating with gtt-addresses has to be done with 64b variables. CC: Kenneth Graunke CC: Chris Wilson Fixes: a363bb2cd0e2 (i965: Allocate VMA in userspace for full-PPGTT systems.) Fixes: c7c6e46f913b (drm/i915: Convert execbuf to use struct-of-array packing for critical fields) Bugzilla: https:/