Re: [Intel-gfx] [PATCH v1] drm/i915: Refactor setting dma info to a common helper

2020-04-17 Thread Chris Wilson
Quoting Ruhl, Michael J (2020-04-17 20:31:52) > >-Original Message- > >From: Chris Wilson > >> diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel-gtt.c > >> index 3d42fc4290bc..4b34a5195c65 100644 > >> --- a/drivers/char/agp/intel-gtt.c > >> +++ b/drivers/char/agp/intel-gtt

Re: [Intel-gfx] [PATCH v1] drm/i915: Refactor setting dma info to a common helper

2020-04-17 Thread Ruhl, Michael J
>-Original Message- >From: Chris Wilson >Sent: Friday, April 17, 2020 3:05 PM >To: Ruhl, Michael J ; intel- >g...@lists.freedesktop.org >Subject: Re: [Intel-gfx] [PATCH v1] drm/i915: Refactor setting dma info to a >common helper > >Quoting Michael J. Ruhl (2020-

Re: [Intel-gfx] [PATCH v1] drm/i915: Refactor setting dma info to a common helper

2020-04-17 Thread Chris Wilson
Quoting Michael J. Ruhl (2020-04-17 19:51:34) > DMA_MASK bit values are different for different generations. > > This will become more difficult to manage over time with the open > coded usage of different versions of the device. > > Fix by: > disallow setting of dma mask in AGP path (< GEN(5)

[Intel-gfx] [PATCH v1] drm/i915: Refactor setting dma info to a common helper

2020-04-17 Thread Michael J. Ruhl
DMA_MASK bit values are different for different generations. This will become more difficult to manage over time with the open coded usage of different versions of the device. Fix by: disallow setting of dma mask in AGP path (< GEN(5) for i915, add dma_mask_size to the device info configurati