Re: [Intel-gfx] [PATCH v12 04/11] drm/i915: Create uC runtime and system suspend/resume helpers

2017-09-29 Thread Michal Wajdeczko
On Fri, 29 Sep 2017 16:13:54 +0200, Sagar Arun Kamble wrote: On 9/29/2017 5:42 PM, Joonas Lahtinen wrote: + Michal, On the principle of code motion first, changes second, I'd like to see the clean split-up from Michal before touching the files much. That way git history will be easier t

Re: [Intel-gfx] [PATCH v12 04/11] drm/i915: Create uC runtime and system suspend/resume helpers

2017-09-29 Thread Sagar Arun Kamble
On 9/29/2017 5:42 PM, Joonas Lahtinen wrote: + Michal, On the principle of code motion first, changes second, I'd like to see the clean split-up from Michal before touching the files much. That way git history will be easier to examine. I think we wanted to get these fixes in prior to restru

Re: [Intel-gfx] [PATCH v12 04/11] drm/i915: Create uC runtime and system suspend/resume helpers

2017-09-29 Thread Joonas Lahtinen
+ Michal, On the principle of code motion first, changes second, I'd like to see the clean split-up from Michal before touching the files much. That way git history will be easier to examine. Few comments below. On Thu, 2017-09-28 at 12:18 +0530, Sagar Arun Kamble wrote: > Prepared generic help

[Intel-gfx] [PATCH v12 04/11] drm/i915: Create uC runtime and system suspend/resume helpers

2017-09-27 Thread Sagar Arun Kamble
Prepared generic helpers intel_uc_suspend, intel_uc_resume, intel_uc_runtime_suspend, intel_uc_runtime_resume. These are called from respective GEM functions. Only exception is intel_uc_resume that needs to be called w/ or w/o GuC loaded in i915_drm_resume path. Changes to add WOPCM condition check