Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-28 Thread Daniel Vetter
On Fri, Jul 25, 2014 at 05:47:11PM -0700, Sun, Daisy wrote: > we have reconsidered good suggestions and evaluated performance and > complexity again. > > Timer Constant callback would continuously wake up CPU and entire > package, results in lower CPU and package C-state and shorter battery life,

Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-25 Thread Sun, Daisy
page flip. Thanks for the valuable input. - Daisy -Original Message- From: daniel.vet...@ffwll.ch [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter Sent: Monday, July 14, 2014 12:04 AM To: Sun, Daisy Cc: Chris Wilson; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [P

Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-25 Thread Sun, Daisy
gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo On Mon, Jul 14, 2014 at 8:59 AM, Daniel Vetter wrote: On Mon, Jul 14, 2014 at 04:22:44AM +, Sun, Daisy wrote: 3) The function will be called when flip happened, this should cover most of the cases. On

Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-25 Thread Daniel Vetter
; > > - Daisy > > > > -Original Message- > > From: daniel.vet...@ffwll.ch [mailto:daniel.vet...@ffwll.ch] On Behalf Of > > Daniel Vetter > > Sent: Monday, July 14, 2014 12:04 AM > > To: Sun, Daisy > > Cc: Chris Wilson; intel-gfx@lists.freede

Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-24 Thread Jesse Barnes
lto:daniel.vet...@ffwll.ch] On Behalf Of > Daniel Vetter > Sent: Monday, July 14, 2014 12:04 AM > To: Sun, Daisy > Cc: Chris Wilson; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo > > On Mon, Jul 14, 2014 at 8:59 AM, Daniel

Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-14 Thread Sun, Daisy
h] On Behalf Of Daniel Vetter Sent: Monday, July 14, 2014 12:04 AM To: Sun, Daisy Cc: Chris Wilson; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo On Mon, Jul 14, 2014 at 8:59 AM, Daniel Vetter wrote: > On Mon, Jul 14, 2014 at 04:22:44AM +0

Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-14 Thread Daniel Vetter
On Mon, Jul 14, 2014 at 8:59 AM, Daniel Vetter wrote: > On Mon, Jul 14, 2014 at 04:22:44AM +, Sun, Daisy wrote: >> 3) The function will be called when flip happened, this should cover >> most of the cases. One exception is background media process without any >> display output, it's relatively

Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-14 Thread Daniel Vetter
From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Thursday, July 10, 2014 11:16 PM > To: Sun, Daisy > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo > > On Thu, Jul 10, 2014 at 07:39:32PM -0700, Sun, Daisy

Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-13 Thread Sun, Daisy
l try to cover it definitely. -Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Thursday, July 10, 2014 11:16 PM To: Sun, Daisy Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo On Thu, Jul 10, 2014 at

Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-10 Thread Chris Wilson
On Thu, Jul 10, 2014 at 07:39:32PM -0700, Sun, Daisy wrote: > > This Software turbo will mainly take place of the hardware driven > interrupt part without touching the boost/idle strategy. > So gen6_rps_boost and gen6_rps_idle will still function for BDW. You still are not addressing that your fu

Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-10 Thread Sun, Daisy
This Software turbo will mainly take place of the hardware driven interrupt part without touching the boost/idle strategy. So gen6_rps_boost and gen6_rps_idle will still function for BDW. I can revise the commit message to clarify. On 7/10/2014 12:07 PM, Chris Wilson wrote: On Thu, Jul 10, 2

Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-10 Thread Chris Wilson
On Thu, Jul 10, 2014 at 11:42:59AM -0700, Sun, Daisy wrote: > > GT is not going to run at a single frequency all the time actually. > It starts from a single frequency, and then will dynamically adjust > according to the GT utilization, either go up or down. > From this perspective, SW turbo funct

Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-10 Thread Sun, Daisy
GT is not going to run at a single frequency all the time actually. It starts from a single frequency, and then will dynamically adjust according to the GT utilization, either go up or down. From this perspective, SW turbo function the same as the HW turbo. For the algorithm, we did go over t

Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-10 Thread Chris Wilson
On Wed, Jul 09, 2014 at 06:00:48PM -0700, Daisy Sun wrote: > BDW supports GT C0 residency reporting in constant time unit. Driver > calculates > GT utilization based on C0 residency and adjusts RP frequency up/down > accordingly. This explanation is a bit thin on the ground for why you want to ru

[Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo

2014-07-09 Thread Daisy Sun
BDW supports GT C0 residency reporting in constant time unit. Driver calculates GT utilization based on C0 residency and adjusts RP frequency up/down accordingly. Signed-off-by: Daisy Sun [torourke: rebased on latest and resolved conflict] Signed-off-by: Tom O'Rourke --- drivers/gpu/drm/i915/i9