Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-15 Thread Dixit, Ashutosh
On Tue, 14 Mar 2023 02:35:07 -0700, Jani Nikula wrote: > Hi Jani, Thanks for the review. I have posted v3, comments inline below. > On Mon, 13 Mar 2023, Ashutosh Dixit wrote: > > On dGfx, the PL1 power limit being enabled and set to a low value results > > in a low GPU operating freq. It also n

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-14 Thread Jani Nikula
On Mon, 13 Mar 2023, Ashutosh Dixit wrote: > On dGfx, the PL1 power limit being enabled and set to a low value results > in a low GPU operating freq. It also negates the freq raise operation which > is done before GuC firmware load. As a result GuC firmware load can time > out. Such timeouts were

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-13 Thread kernel test robot
Hi Ashutosh, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [cannot apply to drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm/drm-next drm-exynos/exynos-drm-next drm-misc/drm-misc-next linus/master v6.3-rc2 next-20230310] [If your

[Intel-gfx] [PATCH v2] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-13 Thread Ashutosh Dixit
On dGfx, the PL1 power limit being enabled and set to a low value results in a low GPU operating freq. It also negates the freq raise operation which is done before GuC firmware load. As a result GuC firmware load can time out. Such timeouts were seen in the GL #8062 bug below (where the PL1 power