Re: [Intel-gfx] [PATCH v2] drm/i915: Fixup userptr mmu notifier registration error handling

2017-10-18 Thread Tvrtko Ursulin
On 18/10/2017 10:07, Daniel Vetter wrote: On Tue, Oct 17, 2017 at 04:09:08PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Avoid dereferencing the error pointer and also avoid returning NULL from i915_mmu_notifier_find since the callers do not expect that. How

Re: [Intel-gfx] [PATCH v2] drm/i915: Fixup userptr mmu notifier registration error handling

2017-10-18 Thread Daniel Vetter
On Tue, Oct 17, 2017 at 04:09:08PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Avoid dereferencing the error pointer and also avoid returning NULL > from i915_mmu_notifier_find since the callers do not expect that. How did my patch return a NULL value? At

Re: [Intel-gfx] [PATCH v2] drm/i915: Fixup userptr mmu notifier registration error handling

2017-10-17 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-10-17 16:09:08) > From: Tvrtko Ursulin > > Avoid dereferencing the error pointer and also avoid returning NULL > from i915_mmu_notifier_find since the callers do not expect that. > > Signed-off-by: Tvrtko Ursulin

[Intel-gfx] [PATCH v2] drm/i915: Fixup userptr mmu notifier registration error handling

2017-10-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Avoid dereferencing the error pointer and also avoid returning NULL from i915_mmu_notifier_find since the callers do not expect that. Signed-off-by: Tvrtko Ursulin Reported-by: Dan Carpenter