Re: [Intel-gfx] [PATCH v2] drm/i915: Initialize the mbus_offset to fix static analysis issue

2021-06-04 Thread Rodrigo Vivi
On Fri, Jun 04, 2021 at 06:22:49PM +0300, Mika Kuoppala wrote: > Rodrigo Vivi writes: > > > On Thu, Jun 03, 2021 at 03:07:54PM -0700, Manasi Navare wrote: > >> Static analysis identified an issue in skl_crtc_allocate_ddb where > >> mbus_offset may be used uninitialized. > >> This patch fixes it.

Re: [Intel-gfx] [PATCH v2] drm/i915: Initialize the mbus_offset to fix static analysis issue

2021-06-04 Thread Mika Kuoppala
Rodrigo Vivi writes: > On Thu, Jun 03, 2021 at 03:07:54PM -0700, Manasi Navare wrote: >> Static analysis identified an issue in skl_crtc_allocate_ddb where >> mbus_offset may be used uninitialized. >> This patch fixes it. > > I'm sorry, but I really cannot see what this tool is seeing... > I even

Re: [Intel-gfx] [PATCH v2] drm/i915: Initialize the mbus_offset to fix static analysis issue

2021-06-04 Thread Rodrigo Vivi
On Thu, Jun 03, 2021 at 03:07:54PM -0700, Manasi Navare wrote: > Static analysis identified an issue in skl_crtc_allocate_ddb where > mbus_offset may be used uninitialized. > This patch fixes it. I'm sorry, but I really cannot see what this tool is seeing... I even tried to look to our internal br

[Intel-gfx] [PATCH v2] drm/i915: Initialize the mbus_offset to fix static analysis issue

2021-06-03 Thread Manasi Navare
Static analysis identified an issue in skl_crtc_allocate_ddb where mbus_offset may be used uninitialized. This patch fixes it. Fixes: 835c176cb1c4 ("drm/i915: Introduce MBUS relative dbuf offsets") Cc: Ville Syrjälä Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/intel_pm.c | 2 +- 1 file