Re: [Intel-gfx] [PATCH v2] drm/i915: Wait for gen3 reset status to be asserted

2018-02-08 Thread Chris Wilson
Quoting Mika Kuoppala (2018-02-08 11:43:50) > Chris Wilson writes: > > > After we assert the reset request (and wait for 20us), when the device > > has been fully reset it asserts the reset-status bit. Before we stop > > requesting the reset and allow the device to

Re: [Intel-gfx] [PATCH v2] drm/i915: Wait for gen3 reset status to be asserted

2018-02-08 Thread Chris Wilson
Quoting Mika Kuoppala (2018-02-08 12:34:08) > Chris Wilson writes: > > > Quoting Mika Kuoppala (2018-02-08 11:43:50) > >> Any thoughts of starting to log the reset attempts > >> with timeout, even if the subsequent reset succeeds? > > > > If it succeeds, do we care?

Re: [Intel-gfx] [PATCH v2] drm/i915: Wait for gen3 reset status to be asserted

2018-02-08 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2018-02-08 11:43:50) >> Any thoughts of starting to log the reset attempts >> with timeout, even if the subsequent reset succeeds? > > If it succeeds, do we care? Capturing why it fails, sure. > > The question being what do

Re: [Intel-gfx] [PATCH v2] drm/i915: Wait for gen3 reset status to be asserted

2018-02-08 Thread Chris Wilson
Quoting Mika Kuoppala (2018-02-08 11:43:50) > Any thoughts of starting to log the reset attempts > with timeout, even if the subsequent reset succeeds? If it succeeds, do we care? Capturing why it fails, sure. The question being what do we want to gain from it? Faster reset by removing timeout

Re: [Intel-gfx] [PATCH v2] drm/i915: Wait for gen3 reset status to be asserted

2018-02-08 Thread Mika Kuoppala
Chris Wilson writes: > After we assert the reset request (and wait for 20us), when the device > has been fully reset it asserts the reset-status bit. Before we stop > requesting the reset and allow the device to return to normal, we should > wait for the reset to be

[Intel-gfx] [PATCH v2] drm/i915: Wait for gen3 reset status to be asserted

2018-02-07 Thread Chris Wilson
After we assert the reset request (and wait for 20us), when the device has been fully reset it asserts the reset-status bit. Before we stop requesting the reset and allow the device to return to normal, we should wait for the reset to be completed. (Similar to how we wait for the device to return