Re: [Intel-gfx] [PATCH v2 01/17] drm/i915/pps: abstract panel power sequencer from intel_dp.c

2021-01-13 Thread Anshuman Gupta
On 2021-01-08 at 19:44:09 +0200, Jani Nikula wrote: > In a long overdue refactoring, split out all panel sequencer code from > intel_dp.c to new intel_pps.[ch]. > > The first part is mostly just code movement as-is, without cleanups or > functional changes. > > We need to add a vlv_get_dpll() hel

Re: [Intel-gfx] [PATCH v2 01/17] drm/i915/pps: abstract panel power sequencer from intel_dp.c

2021-01-13 Thread Jani Nikula
Anshuman, thanks a bunch for the reviews, much appreciated! ...but may I ask for reviews on this one too, as starting to push the patches hinges on the first one. I'd rather start pushing the ready ones than repost the entire series for the required changes. Thanks, Jani. On Fri, 08 Jan 2021,

[Intel-gfx] [PATCH v2 01/17] drm/i915/pps: abstract panel power sequencer from intel_dp.c

2021-01-08 Thread Jani Nikula
In a long overdue refactoring, split out all panel sequencer code from intel_dp.c to new intel_pps.[ch]. The first part is mostly just code movement as-is, without cleanups or functional changes. We need to add a vlv_get_dpll() helper to get at the vlv/chv dpll from pps code. v2: Rebase. Signed