Re: [Intel-gfx] [PATCH v2 01/21] drm: Export drm_dev_init() for subclassing

2016-06-01 Thread Chris Wilson
On Wed, Jun 01, 2016 at 12:01:44PM +0200, Daniel Vetter wrote: > With the one bug in the error handling fixed, and the kerneldoc augmented: diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index f0553ccd4f71..4f3d3bba08f7 100644 --- a/drivers/gpu/drm/drm_drv.c +++ b/drivers/gpu/d

Re: [Intel-gfx] [PATCH v2 01/21] drm: Export drm_dev_init() for subclassing

2016-06-01 Thread Daniel Vetter
On Wed, Jun 01, 2016 at 12:01:44PM +0200, Daniel Vetter wrote: > On Mon, May 30, 2016 at 09:38:19AM +0100, Chris Wilson wrote: > > In order to allow drivers to pack their privates and drm_device into one > > struct (e.g. for subclassing), export the initialisation routines for > > struct drm_device

Re: [Intel-gfx] [PATCH v2 01/21] drm: Export drm_dev_init() for subclassing

2016-06-01 Thread Daniel Vetter
On Mon, May 30, 2016 at 09:38:19AM +0100, Chris Wilson wrote: > In order to allow drivers to pack their privates and drm_device into one > struct (e.g. for subclassing), export the initialisation routines for > struct drm_device. > > v2: Missed return ret. That error path had only one job to do! >

[Intel-gfx] [PATCH v2 01/21] drm: Export drm_dev_init() for subclassing

2016-05-30 Thread Chris Wilson
In order to allow drivers to pack their privates and drm_device into one struct (e.g. for subclassing), export the initialisation routines for struct drm_device. v2: Missed return ret. That error path had only one job to do! Signed-off-by: Chris Wilson Cc: Daniel Vetter Cc: dri-de...@lists.free